MPDX-8850 Connect GraphQL to Ministry Reminders

[kegrimes]

Description

Connect graphQL query and update mutation to Ministry Partner Reminders frontend.

Testing

• Go to /6bbc265f-ec81-4b23-b297-5bd298c4d619/reports/mpReminders
• Scroll through the donor list
• Check that infinity scroll still works
• Change a select option & refresh the page
• Check that it successfully updated

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Bundle sizes [mpdx-react]

Compared against 26b469f

No significant changes found

[wjames111]

I'm dumb I thought it autosaved, looks really good!

[wjames111]

Do you think we could make this save on change rather then a specific save button, I was being dumb but I do think it's a little more intuitive that way or even moving the save button below the list rather then above it.

[kegrimes]

I think the original design on staff web had the save button below the table. Daniel thought that it should go above so people don't have to scroll down to see that they need to save it. I think autosaving could be good, but also since the list of donors can be very large, maybe users want to double check what they are changing before implementing those changes. Or maybe they want to revert back to their original changes, but since it is a large list, they wouldn't be able to remember what was the previous status if we use autosave. What do you think? We could definitely get Daniel or Ryan's opinion on it.

Also, currently I am just picking the first designation account that is returned. I don't think that should be the case, but I am also not completely sure how to differentiate which account is desired. Would you happen to have any ideas?

[wjames111]

@kegrimes those are fair points, and probably a good reason to stick with the save button. If Daniel wanted it up top then go with that. You could always double check with Ryan, but it sounds like the way you have it is good.

So is the problem that there are many designation accounts and each designation account has many ministry partner reminders, but you just want to list all ministry partner reminders?

[wjames111]

Thanks for making these changes! I think we just need to figure out which designation account to show now. If I understand the issue correctly, I don't have any good solutions at the moment. It might need to wait for Caleb or Daniel's input. Running it by Ryan might also be a good idea.

[kegrimes]

@dr-bizz @canac I am currently hardcoding the report to display the ministry partners for the first designation account returned by the query. I am wondering what is the intended logic for selecting which to display. I may be missing some context on how this is done. Let me know what your thoughts are!

[canac]

I am currently hardcoding the report to display the ministry partners for the first designation account returned by the query. I am wondering what is the intended logic for selecting which to display. I may be missing some context on how this is done. Let me know what your thoughts are!

A lot of the reports have a designation account selector in the sidebar. Maybe you could do something similar? I'm wondering though why the GraphQL endpoint makes the designation account filter required? I wonder if it would be possible to show contacts from all designation accounts so that users don't have to select one unless they truly need to filter by designation account. That would be a question for whoever set up the GraphQL endpoint.

[kegrimes]

@canac I have added a primaryDesignation field to GetUserQuery that will get a user's most recently updated designation number from their key account (stored in person_key_account database table). In order to get test data, I added the designation number 0864190 to the test account.

However, it only works for accountListId 6bbc265f-ec81-4b23-b297-5bd298c4d619 (Caleb Cox) since that designation number belongs to that account. If you change accounts within the test account, it will give the error Designation account not found or does not belong to this account list. This makes me think maybe the primary designation number is not correct. What are your thoughts?

Refer to this merged PR for API changes.