-
-
Notifications
You must be signed in to change notification settings - Fork 397
West Midlands | Jan-2026 | Arunkumar Akilan | Sprint 1 | Wireframe to Web Code #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
West Midlands | Jan-2026 | Arunkumar Akilan | Sprint 1 | Wireframe to Web Code #995
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The content in the PR Description is not yet properly formatted using the Markdown syntax. Can you update its format accordingly? To learn the Markdown syntax, please refer to |
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you center the PAGE TITLE and the PAGE SUBTITLE (the part that replace "A SHORT DESCRIPTION")?
-
(Optional change) If you are up to some challenge to further improve the layout, leave more space above and below the border of READ ME link, and keep the spacing consistent regardless of the amount of content in the articles.
| <nav> | ||
| <a href="#">Home</a> | ||
| <a href="#">About</a> | ||
| <a href="mailto:arunnkumar7@gmail.com">Contact</a> | ||
| <a href="https://github.com/arunkumarakilan" target="_blank" rel="noopener">GitHub</a> | ||
| <a href="https://www.linkedin.com/in/arunkumar-akilan-0a87aa3a1/" target="_blank" rel="noopener">LinkedIn</a> | ||
| </nav> | ||
| <p>© 2026 Arunkumar Akilan</p> | ||
|
|
||
| </footer> | ||
| </body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you improve the indentation of this code?
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| This page explains the basics of Git, the purpose of a README file, and how wireframes help developers plan and structure a webpage before writing code. It gives a clear overview of how these tools are used together in real-world web development. | ||
| </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 13 can be better formatted as:
<p>
This page explains the basics of Git, the purpose of a README file, and how wireframes
help developers plan and structure a webpage before writing code. It gives a clear overview
of how these tools are used together in real-world web development.
</p>
To understand why, you can ask AI these questions:
- How HTML treats multiple whitespace characters in text?
- What's the advantage of not writing a long paragraph of text in a single line in HTML?
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.
Please note that if there are syntax errors in the code, the "Prettier" extension may not format HTML code properly.

#Self checklist
[x] I have titled my PR with
West Midlands | Jan-2026 | Arunkumar Akilan | Wireframe to Web Code
[x] My changes meet the requirements of the task
[x] I have tested my changes locally in the browser
[x] My changes follow the CYF style guide
##Changelist
Converted the provided wireframe into a semantic HTML webpage
Added header with page title and description
Created three articles explaining:
Purpose of a Wireframe
Purpose of a README file
What a Git branch is
Styled the layout using CSS Grid to match the wireframe (first article full width, second and third side by side)
Added a footer with navigation links and contact information
Ensured the page scores 100 for Accessibility using Lighthouse
Questions
I would appreciate feedback on my CSS Grid usage and overall semantic structure.
Any suggestions to further improve accessibility or layout consistency are welcome.