Skip to content

Conversation

@pathywang
Copy link

@pathywang pathywang commented Jan 18, 2026

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I created a new branch because my previous one became a bit messy. I checked the project using Lighthouse; Best Practices scored 93, and all other categories scored 100, which I hope is acceptable. I also shared my code with an AI tool to help identify and correct some typos.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0f0e310
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974e818aa4357000826f0b0
😎 Deploy Preview https://deploy-preview-979--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 18, 2026
@pathywang pathywang changed the title London l ITP-JAN-2016 l ping wang l onboarding l wireframe London l ITP-JAN-2016 l ping wang l sprint 1 l wireframe Jan 18, 2026
@github-actions

This comment has been minimized.

@pathywang pathywang changed the title London l ITP-JAN-2016 l ping wang l sprint 1 l wireframe London l ITP-Jan-2016 l Ping Wang l Sprint 1 l Wireframe Jan 18, 2026
@github-actions

This comment has been minimized.

@pathywang pathywang changed the title London l ITP-Jan-2016 l Ping Wang l Sprint 1 l Wireframe London | ITP-Jan-2016 | Ping Wang | Sprint 1 | Wireframe Jan 18, 2026
@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 18, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your PR Description

1

Can you edit the Markdown syntax of the checkboxes to make them looks like this

  • I have tested my changes

instead of like this:
[x] I have tested my changes

2

It would be better to keep the "Changelist" header.

3

There are some typos and grammar mistakes in the description.
Suggestion: Use AI to check for typos, grammar mistakes, and even suggest improvements, and learn from the process.

In index.html

The HTML code looks good.
However, the text content has some typos.
Suggestion: Share your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency.
It can often help us catch errors, improve consistency, and reinforce best practices.

</article>
</main>
<footer>
<p>ITP-JAN-25 | Ping Wang | Module: Onboarding | wifeframe</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 26 and Wireframe?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 23, 2026
@pathywang pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 24, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 24, 2026

There are still some typos or incorrectly spelled words in the PR description and in index.html.
Have you tried sharing the whole HTML code to an AI tool and ask it to check for typo and consistency?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 24, 2026
@pathywang pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 24, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 25, 2026

Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants