-
-
Notifications
You must be signed in to change notification settings - Fork 396
London | ITP-Jan-2016 | Ping Wang | Sprint 1 | Wireframe #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your PR Description
1
Can you edit the Markdown syntax of the checkboxes to make them looks like this
- I have tested my changes
instead of like this:
[x] I have tested my changes
2
It would be better to keep the "Changelist" header.
3
There are some typos and grammar mistakes in the description.
Suggestion: Use AI to check for typos, grammar mistakes, and even suggest improvements, and learn from the process.
In index.html
The HTML code looks good.
However, the text content has some typos.
Suggestion: Share your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency.
It can often help us catch errors, improve consistency, and reinforce best practices.
Wireframe/index.html
Outdated
| </article> | ||
| </main> | ||
| <footer> | ||
| <p>ITP-JAN-25 | Ping Wang | Module: Onboarding | wifeframe</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be 26 and Wireframe?
|
There are still some typos or incorrectly spelled words in the PR description and in |
|
Well done. |

Changelist
I created a new branch because my previous one became a bit messy. I checked the project using Lighthouse; Best Practices scored 93, and all other categories scored 100, which I hope is acceptable. I also shared my code with an AI tool to help identify and correct some typos.