Skip to content

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Wireframe to Web Code #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mahmoudshaabo1984 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Wireframe to Web Code #1038

mahmoudshaabo1984 wants to merge 3 commits into from

Conversation

@mahmoudshaabo1984
Copy link

@mahmoudshaabo1984 mahmoudshaabo1984 commented Jan 24, 2026 •
edited
Loading

I have successfully completed the Wireframe to Web Code assignment for Sprint 1.

Work Done:

  • Created a semantic HTML5 skeleton using header, nav, main, article, and footer tags.
  • Linked the external style.css file to the HTML document.
  • Organized the content structure to match the provided wireframe layout.
  • Verified that the styles are correctly applied to the HTML elements.<!--

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@netlify
Copy link

netlify bot commented Jan 24, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1154e97
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974e57c271d060008ff6d84
😎 Deploy Preview https://deploy-preview-1038--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@mahmoudshaabo1984 mahmoudshaabo1984 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mahmoudshaabo1984 mahmoudshaabo1984 changed the title Sheffield | Wireframe to Web Code | Mahmoud Shaabo Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Wireframe to Web Code Jan 24, 2026
@mahmoudshaabo1984
Update: Added 3 articles as per wireframe requirements
b03d5d3
@mahmoudshaabo1984
Refactor: Improve wireframe skeleton and CSS variables
1154e97 
- Enhanced CSS Variables with more semantic naming and additional color/spacing options

- Added responsive design with media queries for mobile devices

- Improved accessibility with ARIA labels and proper navigation links

- Added hover effects for better user interaction

- Improved semantic HTML structure with descriptive comments

- Standardized spacing and layout using CSS Variables consistently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mahmoudshaabo1984