Skip to content

Conversation

@Richiealx
Copy link

@Richiealx Richiealx commented Jan 24, 2026

Learners, PR Template

Self checklist

Changelist

  • Built a semantic HTML form to collect t-shirt order details
  • Added required validation for name (minimum 2 characters and not whitespace-only) and email
  • Limited colour choice to three radio button options
  • Limited size choice to six predefined options
  • Used fieldset and legend for accessible grouping
  • No CSS or JavaScript used

Testing

  • Opened the page locally with Live Server
  • Confirmed browser validation blocks:
    • empty submit
    • 1-character name
    • whitespace-only name (e.g. spaces only)
    • invalid email format
    • missing colour selection
    • missing size selection
  • Ran Lighthouse (Desktop) and got Accessibility score = 100

Questions

  • Is my use of semantic HTML and form validation appropriate?
  • Are there any accessibility or structure improvements you would recommend?
  • I added a pattern attribute to reject whitespace-only names, as suggested. Please let me know if this meets expectations.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 9ff77c3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974f282471d020007393584
😎 Deploy Preview https://deploy-preview-1034--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Richiealx Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@Richiealx Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@Richiealx Richiealx added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 25, 2026

Well done!

@cjyuan
Copy link
Contributor

cjyuan commented Jan 25, 2026

Is my use of semantic HTML and form validation appropriate?
Are there any accessibility or structure improvements you would recommend?

I am afraid AI probably knows more than I do on these topics.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants