-
Notifications
You must be signed in to change notification settings - Fork 47
alveena/backend refactor pt2 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alveenahanif
wants to merge
180
commits into
Code-4-Community:main
Choose a base branch
from
Code-4-Community:alveena/backend-refactor-pt2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
alveena/backend refactor pt2 #107
alveenahanif
wants to merge
180
commits into
Code-4-Community:main
from
Code-4-Community:alveena/backend-refactor-pt2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hp adding migrations - test
adding comments to explain type error
Create application entity
[Issue #16] - create discipline entity in TypeORM
…le and application types
added testing removed deprecated on update adding user authentication by adding provider deleted old migration file and used just the main one
…ation implement validation checks
…ipline-routes added discipline CRUD routes
…utes create basic CRUD ops for disciplines
…y + DTO instead of previous strings, refactored tests to match new entity + DTO
chakraprovider wrapper in main.tsx + table
…-refactor new entities + tests
…factoring-pt-3-learner-info
…actoring-pt-3-learner-info
Renames the learner entity to Applicant and replaces id with appId as the identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes backend-refactor-pt2
This PR adds two new required fields to the Application entity to align with the updated data model.
The DTO and service tests were updated to ensure the new fields are properly validated and tested.
Changes made: