diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 845e69d1..d1a035d2 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ -* @seba-aln @jguz-pubnub @wkal-pubnub -README.md @techwritermat @kazydek @seba-aln @jguz-pubnub +* @parfeon @jguz-pubnub +README.md @techwritermat @kazydek @parfeon @jguz-pubnub diff --git a/pubnub/pnconfiguration.py b/pubnub/pnconfiguration.py index 73c8aa81..4e1d0d3d 100644 --- a/pubnub/pnconfiguration.py +++ b/pubnub/pnconfiguration.py @@ -1,5 +1,5 @@ import warnings -from typing import Any +from typing import Any, Optional from copy import deepcopy from Cryptodome.Cipher import AES from pubnub.enums import PNHeartbeatNotificationOptions, PNReconnectionPolicy @@ -14,16 +14,19 @@ class PNConfiguration(object): DEFAULT_CRYPTO_MODULE = LegacyCryptoModule _locked = False - def __init__(self): + def __init__(self, + subscribe_key: Optional[str] = None, + publish_key: Optional[str] = None, + uuid: Optional[str] = None): # TODO: add validation - self._uuid = None + self._uuid = uuid self.origin = "ps.pndsn.com" self.ssl = True self.non_subscribe_request_timeout = 10 self.subscribe_request_timeout = 310 self.connect_timeout = 10 - self.subscribe_key = None - self.publish_key = None + self.subscribe_key = subscribe_key + self.publish_key = publish_key self.secret_key = None self.cipher_key = None self._cipher_mode = AES.MODE_CBC