Skip to content

Chat input part must not depend on IAgentSessionsService.model #283856

@bpasero

Description

@bpasero

Just came across this code:

this.agentSessionsService.model.onDidChangeSessions,

This is a very bad weird cyclic dependency that needs to go away:

  • with this you now depend on the chat sessions view model
  • my view model is updated by the chat sessions service and providers
  • which itself is updated from chat models
  • now the chat input part is already belonging to some chat model
  • 👉 why can it not use the chat model for its business

//cc @lszomoru @connor4312 @rebornix @roblourens

Metadata

Metadata

Labels

debtCode quality issuesimportantIssue identified as high-priority

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions