diff --git a/src/VirtualClient/TestResources/WebFundamentalsResults.xml b/src/VirtualClient/TestResources/WebFundamentalsResults.xml index 88819f5cfa..0bfac7992e 100644 --- a/src/VirtualClient/TestResources/WebFundamentalsResults.xml +++ b/src/VirtualClient/TestResources/WebFundamentalsResults.xml @@ -623,10 +623,10 @@ This test contained errors. - An error occured collecting server information data. Check that WMI is available. + An error occurred collecting server information data. Check that WMI is available. An error was encountered querying remote server information. This value may be wrong. - An error occured during the collection of this counter. - An error occured during the collection of performance counters. + An error occurred during the collection of this counter. + An error occurred during the collection of performance counters. HTTP.sys cache hits number is low: either warmed up during cold test or didn't warm up enough during normal test. diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Compressor7zip/Compressor7zipExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Compressor7zip/Compressor7zipExecutorTests.cs index 78cc3b4427..bddac3e42c 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Compressor7zip/Compressor7zipExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Compressor7zip/Compressor7zipExecutorTests.cs @@ -55,7 +55,7 @@ public void SetupTest() } [Test] - public void Compressor7zipStateIsSerializeable() + public void Compressor7zipStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkExecutorTests.cs index 051d274dc6..9e140f6446 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkExecutorTests.cs @@ -81,7 +81,7 @@ public async Task CoreMarkExecutorExecutesTheExpectedCommandInWindows() } [Test] - public async Task CoreMarkExecutorExcutesAllowsThreadOverWrite() + public async Task CoreMarkExecutorExecutesAllowsThreadOverWrite() { this.SetupTest(PlatformID.Unix); this.Parameters = new Dictionary() diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkProExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkProExecutorTests.cs index 95cab28cf9..b3e161ffe4 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkProExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/CoreMark/CoreMarkProExecutorTests.cs @@ -34,7 +34,7 @@ public void SetupTest(PlatformID platform) } [Test] - public async Task CoreMarkProExecutorExcutesAsExpectedInLinux() + public async Task CoreMarkProExecutorExecutesAsExpectedInLinux() { this.SetupTest(PlatformID.Unix); this.ProcessManager.OnCreateProcess = (cmd, args, wd) => @@ -52,7 +52,7 @@ public async Task CoreMarkProExecutorExcutesAsExpectedInLinux() } [Test] - public async Task CoreMarkProExecutorExcutesAsExpectedInWindows() + public async Task CoreMarkProExecutorExecutesAsExpectedInWindows() { this.SetupTest(PlatformID.Win32NT); this.ProcessManager.OnCreateProcess = (cmd, args, wd) => diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/CtsTraffic/CtsTrafficExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/CtsTraffic/CtsTrafficExecutorTests.cs index f193daf084..7771574efd 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/CtsTraffic/CtsTrafficExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/CtsTraffic/CtsTrafficExecutorTests.cs @@ -56,7 +56,7 @@ public void CtsTrafficDatabaseStateObjectsAreJsonSerializable() } [Test] - public async Task CtsTrafficClientExecutorIntializesTheExpectedAPIClients_MultiVM_Environment() + public async Task CtsTrafficClientExecutorInitializesTheExpectedAPIClients_MultiVM_Environment() { this.SetupTest(); using (var executor = new TestCtsTrafficExecutor(this.Dependencies, this.Parameters)) diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchClientExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchClientExecutorTests.cs index fe71d994b8..1b3e468065 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchClientExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchClientExecutorTests.cs @@ -108,7 +108,7 @@ public void SetupTest() } [Test] - public async Task DeathStarBenchClientExecutorIntializeLocalAPIClientOnSingleVMSetup() + public async Task DeathStarBenchClientExecutorInitializeLocalAPIClientOnSingleVMSetup() { this.mockFixture.Dependencies.RemoveAll(); using (TestDeathStarBenchClientExecutor executor = new TestDeathStarBenchClientExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) @@ -121,7 +121,7 @@ public async Task DeathStarBenchClientExecutorIntializeLocalAPIClientOnSingleVMS } [Test] - public async Task DeathStarBenchClientExecutorIntializeServerAPIClientOnMultiVMSetup() + public async Task DeathStarBenchClientExecutorInitializeServerAPIClientOnMultiVMSetup() { using (TestDeathStarBenchClientExecutor executor = new TestDeathStarBenchClientExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) { @@ -139,7 +139,7 @@ public async Task DeathStarBenchClientExecutorIntializeServerAPIClientOnMultiVMS public async Task DeathStarBenchClientExecutorExecutesExpectedCommands_SocialNetworkScenario_MultiVM() { string serviceName = "socialnetwork"; - string binaryPath = this.mockFixture.PlatformSpecifics.Combine("linux-x64", serviceName.ToLower(), "wrk2"); + string binaryPath = this.mockFixture.PlatformSpecifics.Combine("linux-x64", serviceName.ToLower(), "work2"); this.mockFixture.Parameters[nameof(DeathStarBenchExecutor.ServiceName)] = serviceName; List expectedCommands = new List diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchExecutorTests.cs index b95ac8efb9..100b915931 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/DeathStarBench/DeathStarBenchExecutorTests.cs @@ -88,7 +88,7 @@ public async Task DeathStarBenchExecutorServerDoesNotStartItselfOnMultiVMScenari } [Test] - public async Task DeathStarBenchExecutorInstallsDepedenciesAsExpected() + public async Task DeathStarBenchExecutorInstallsDependenciesAsExpected() { this.SetupTest(PlatformID.Unix); diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Gzip/GzipExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Gzip/GzipExecutorTests.cs index 5168ad4029..e4d85d2f66 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Gzip/GzipExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Gzip/GzipExecutorTests.cs @@ -63,7 +63,7 @@ public void SetupDefaultBehavior() } [Test] - public void GzipStateIsSerializeable() + public void GzipStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/HPLinpack/HPLinpackExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/HPLinpack/HPLinpackExecutorTests.cs index 09ff8a1327..120d557ea6 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/HPLinpack/HPLinpackExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/HPLinpack/HPLinpackExecutorTests.cs @@ -22,19 +22,19 @@ public class HPLinpackExecutorTests private MockFixture mockFixture; private DependencyPath mockPackage; - private DependencyPath mockPerformanceLibariesPackage; + private DependencyPath mockPerformanceLibrariesPackage; private string exampleResults; private void SetupTest(PlatformID platform = PlatformID.Unix, Architecture architecture = Architecture.X64) { this.mockFixture = new MockFixture(); this.mockPackage = new DependencyPath("HPL", this.mockFixture.GetPackagePath("hplinpack")); - this.mockPerformanceLibariesPackage = new DependencyPath("hplperformancelibraries", this.mockFixture.GetPackagePath("hplperformancelibraries")); + this.mockPerformanceLibrariesPackage = new DependencyPath("hplperformancelibraries", this.mockFixture.GetPackagePath("hplperformancelibraries")); this.mockFixture.Setup(platform, architecture); this.mockFixture.SetupPackage(this.mockPackage); - this.mockFixture.SetupPackage(this.mockPerformanceLibariesPackage); + this.mockFixture.SetupPackage(this.mockPerformanceLibrariesPackage); this.mockFixture.FileSystem.Setup(fe => fe.File.Exists(It.IsAny())).Returns(true); this.mockFixture.FileSystem.Setup(fe => fe.File.Exists(null)).Returns(false); diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Lzbench/LzbenchExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Lzbench/LzbenchExecutorTests.cs index bebcfe8756..2962c8dc8b 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Lzbench/LzbenchExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Lzbench/LzbenchExecutorTests.cs @@ -53,7 +53,7 @@ public void SetupDefaultBehavior() } [Test] - public void LzbenchStateIsSerializeable() + public void LzbenchStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/MLPerf/MLPerfExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/MLPerf/MLPerfExecutorTests.cs index c9121cee0e..14dc01cbbd 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/MLPerf/MLPerfExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/MLPerf/MLPerfExecutorTests.cs @@ -55,7 +55,7 @@ public void MLPerfExecutorThrowsOnUnsupportedLinuxDistro() } [Test] - public void MLPerfStateIsSerializeable() + public void MLPerfStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/NASParallelBench/NASParallelBenchExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/NASParallelBench/NASParallelBenchExecutorTests.cs index 822c840007..c1932fdff0 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/NASParallelBench/NASParallelBenchExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/NASParallelBench/NASParallelBenchExecutorTests.cs @@ -91,7 +91,7 @@ public async Task NASParallelBenchExecutorRunsExpectedCommandForBuild() } } [Test] - public async Task NASParallelBenchExecutorCreatesExpectedStateOnSuccessfullBuild() + public async Task NASParallelBenchExecutorCreatesExpectedStateOnSuccessfulBuild() { this.SetupTest(PlatformID.Unix); diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSExecutorTests2.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSExecutorTests2.cs index 97f2b113b5..4532ac9d84 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSExecutorTests2.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/CPS/CPSExecutorTests2.cs @@ -153,7 +153,7 @@ public async Task CPSExecutorInitializesItsDependencyPackageAsExpected_Windows(P [TestCase(PlatformID.Unix, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Server)] - public async Task CPSExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup_Linux(PlatformID platformID, Architecture architecture, string role) + public async Task CPSExecutorInitializeServerAPIClientForClientRoleOnMultiVMSetup_Linux(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestCPSExecutor executor = new TestCPSExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) @@ -182,7 +182,7 @@ public async Task CPSExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup [TestCase(PlatformID.Win32NT, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Server)] - public async Task CPSExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup_Windows(PlatformID platformID, Architecture architecture, string role) + public async Task CPSExecutorInitializeServerAPIClientForClientRoleOnMultiVMSetup_Windows(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestCPSExecutor executor = new TestCPSExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteExecutorTests2.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteExecutorTests2.cs index 40352989b2..6bcff8643b 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteExecutorTests2.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/Latte/LatteExecutorTests2.cs @@ -131,7 +131,7 @@ public async Task LatteExecutorInitializesItsDependencyPackageAsExpected(Platfor [TestCase(PlatformID.Win32NT, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Server)] - public async Task LatteExecutorIntializeServerAPIClientAndLocalAPIClientOnMultiVMSetup(PlatformID platformID, Architecture architecture, string role) + public async Task LatteExecutorInitializeServerAPIClientAndLocalAPIClientOnMultiVMSetup(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestLatteExecutor executor = new TestLatteExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpExecutorTests2.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpExecutorTests2.cs index 31319f9836..e1a6a12c8b 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpExecutorTests2.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/NTttcp/NTttcpExecutorTests2.cs @@ -185,7 +185,7 @@ public async Task NTttcpExecutorInitializesItsDependencyPackageAsExpected_Unix(P [TestCase(PlatformID.Win32NT, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Win32NT, Architecture.Arm64, ClientRole.Server)] - public async Task NTttcpExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup_Win(PlatformID platformID, Architecture architecture, string role) + public async Task NTttcpExecutorInitializeServerAPIClientForClientRoleOnMultiVMSetup_Win(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestNTttcpExecutor executor = new TestNTttcpExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) @@ -213,7 +213,7 @@ public async Task NTttcpExecutorIntializeServerAPIClientForClientRoleOnMultiVMSe [TestCase(PlatformID.Unix, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Server)] - public async Task NTttcpExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup_Unix(PlatformID platformID, Architecture architecture, string role) + public async Task NTttcpExecutorInitializeServerAPIClientForClientRoleOnMultiVMSetup_Unix(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestNTttcpExecutor executor = new TestNTttcpExecutor(this.mockFixture.Dependencies, this.mockFixture.Parameters)) diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/SockPerf/SockPerfExecutorTests2.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/SockPerf/SockPerfExecutorTests2.cs index 8bd42b6ce2..273bc7de26 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/SockPerf/SockPerfExecutorTests2.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Network2/SockPerf/SockPerfExecutorTests2.cs @@ -122,7 +122,7 @@ public async Task SockPerfExecutorInitializesItsDependencyPackageAsExpected(Plat [TestCase(PlatformID.Unix, Architecture.X64, ClientRole.Server)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Client)] [TestCase(PlatformID.Unix, Architecture.Arm64, ClientRole.Server)] - public async Task SockPerfExecutorIntializeServerAPIClientForClientRoleOnMultiVMSetup(PlatformID platformID, Architecture architecture, string role) + public async Task SockPerfExecutorInitializeServerAPIClientForClientRoleOnMultiVMSetup(PlatformID platformID, Architecture architecture, string role) { this.SetupTest(platformID, architecture, role); using (TestSockPerfExecutor executor = new TestSockPerfExecutor(this.Dependencies, this.Parameters)) diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/Pbzip2/Pzip2ExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/Pbzip2/Pzip2ExecutorTests.cs index e4990431a3..214612f8e3 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/Pbzip2/Pzip2ExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/Pbzip2/Pzip2ExecutorTests.cs @@ -62,7 +62,7 @@ public void SetupDefaultBehavior() } [Test] - public void Pbzip2StateIsSerializeable() + public void Pbzip2StateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecCpuExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecCpuExecutorTests.cs index 9b68802add..e9719097e9 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecCpuExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecCpuExecutorTests.cs @@ -31,7 +31,7 @@ public class SpecCpuExecutorTests private DependencyPath mockPackage; [Test] - public void SpecCpuStateIsSerializeable() + public void SpecCpuStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecViewExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecViewExecutorTests.cs index 9e8a2f8575..6e5373fe64 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecViewExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/SPEC/SpecViewExecutorTests.cs @@ -85,7 +85,7 @@ public async Task SpecViewExecutorRenamedResultsDirAsExpected(PlatformID platfor string mockResultDir = this.mockFixture.Combine(this.mockSpecViewExeDir, "results_19991231T235959"); string mockHistoryResultsDir = this.mockFixture.Combine(this.mockSpecViewExeDir, "hist_" + Path.GetFileName(mockResultDir)); - // Set up the mock directory to return the mock result dir when the test executor tries to find a dir that starts wth "results_" + // Set up the mock directory to return the mock result dir when the test executor tries to find a dir that starts with "results_" mockFixture.Directory.Setup(dir => dir.GetDirectories(this.mockSpecViewExeDir, "results_*", SearchOption.TopDirectoryOnly)).Returns(new[] { mockResultDir }); // Set up the mock directory to increment resultRenamed by 1 when the test executor tries to rename the result directory diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/JsonMetricsParserTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/JsonMetricsParserTests.cs index 9006dd0051..49d7cad94e 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/JsonMetricsParserTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/ScriptExecutor/JsonMetricsParserTests.cs @@ -60,7 +60,7 @@ public void JsonMetricsParserThrowsIfTheJsonArrayResultsHaveInvalidMetrics() } [Test] - public void JsonMetricsParserThrowsIfTheJsonArrayResultsHaveMisingMetricName() + public void JsonMetricsParserThrowsIfTheJsonArrayResultsHaveMissingMetricName() { string rawText = "[\r\n\t{\r\n\t\t\"Value\": 0,\r\n\t\t\"Unit\": \"unit3\",\r\n\t\t\"MetaData\": {\r\n\t\t\t\"metadata1\": \"m5\",\r\n\t\t\t\"metadata2\": \"m6\"\r\n\t\t}\r\n\t},\r\n\t{\r\n\t\t\"Name\": \"metric4\",\r\n\t\t\"Value\": 1.0,\r\n\t\t\"MetaData\": {\r\n\t\t\t\"metadata1\": \"m7\"\r\n\t\t}\r\n\t}\r\n]"; diff --git a/src/VirtualClient/VirtualClient.Actions.UnitTests/SuperBenchmark/SuperBenchmarkExecutorTests.cs b/src/VirtualClient/VirtualClient.Actions.UnitTests/SuperBenchmark/SuperBenchmarkExecutorTests.cs index ed727f84f8..76f34432f0 100644 --- a/src/VirtualClient/VirtualClient.Actions.UnitTests/SuperBenchmark/SuperBenchmarkExecutorTests.cs +++ b/src/VirtualClient/VirtualClient.Actions.UnitTests/SuperBenchmark/SuperBenchmarkExecutorTests.cs @@ -54,7 +54,7 @@ public void SetupDefaultBehavior() } [Test] - public void SuperBenchmarkStateIsSerializeable() + public void SuperBenchmarkStateIsSerializable() { State state = new State(new Dictionary { diff --git a/src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipMetricsParser.cs index 85525a3b56..586789e854 100644 --- a/src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipMetricsParser.cs @@ -64,7 +64,7 @@ public override IList Parse() metrics.Add(new Metric( "Compression_Ratio", (Convert.ToDouble(this.SizeAndTime.Rows[2].ItemArray[2]) / Convert.ToDouble(this.SizeAndTime.Rows[0].ItemArray[2])) * 100, - "precentage", + "percentage", relativity: MetricRelativity.LowerIsBetter, verbosity: 2)); diff --git a/src/VirtualClient/VirtualClient.Actions/BlenderBenchmark/BlenderBenchmarkExecutor.cs b/src/VirtualClient/VirtualClient.Actions/BlenderBenchmark/BlenderBenchmarkExecutor.cs index 9b26ba8cf9..d26013cd94 100644 --- a/src/VirtualClient/VirtualClient.Actions/BlenderBenchmark/BlenderBenchmarkExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/BlenderBenchmark/BlenderBenchmarkExecutor.cs @@ -258,7 +258,7 @@ private async Task InitializePackageLocationAsync(CancellationToken cancellation /// private string GenerateCommandArgument(string scene, string deviceType) { - // --verbosity 3 gives detailed error messsage if Blender fails to run + // --verbosity 3 gives detailed error message if Blender fails to run return $"benchmark --blender-version {this.BlenderVersion} --device-type {deviceType} {scene} --json --verbosity 3"; } } diff --git a/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkExecutor.cs b/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkExecutor.cs index d08765e063..0a7dff50ca 100644 --- a/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkExecutor.cs @@ -66,7 +66,7 @@ public string CompilerVersion } /// - /// Allos overwrite to Coremark process thread count. + /// Allows overwrite to Coremark process thread count. /// public int ThreadCount { diff --git a/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkProExecutor.cs b/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkProExecutor.cs index 4e8aa87009..5dd4016a81 100644 --- a/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkProExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/CoreMark/CoreMarkProExecutor.cs @@ -60,7 +60,7 @@ public string CompilerVersion } /// - /// Allos overwrite to Coremark process thread count. + /// Allows overwrite to Coremark process thread count. /// public int ThreadCount { diff --git a/src/VirtualClient/VirtualClient.Actions/DCGMI/DCGMIExecutor.cs b/src/VirtualClient/VirtualClient.Actions/DCGMI/DCGMIExecutor.cs index 7dc12bf87c..5a4b62b754 100644 --- a/src/VirtualClient/VirtualClient.Actions/DCGMI/DCGMIExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/DCGMI/DCGMIExecutor.cs @@ -134,7 +134,7 @@ public string LinuxCudaVersion } /// - /// Initializes enviroment to run DCGMI. + /// Initializes environment to run DCGMI. /// /// Provides context information that will be captured with telemetry events. /// A token that can be used to cancel the operation. diff --git a/src/VirtualClient/VirtualClient.Actions/DeathStarBench/DeathStarBenchServerExecutor.cs b/src/VirtualClient/VirtualClient.Actions/DeathStarBench/DeathStarBenchServerExecutor.cs index 79fca0da75..6f41df3f49 100644 --- a/src/VirtualClient/VirtualClient.Actions/DeathStarBench/DeathStarBenchServerExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/DeathStarBench/DeathStarBenchServerExecutor.cs @@ -134,7 +134,7 @@ await this.ExecuteCommandAsync(@$"bash -c ""{this.PythonExecutablePath} scripts/ } catch { - throw new Exception($"Error occured at starting server in {this.ServiceName}"); + throw new Exception($"Error occurred at starting server in {this.ServiceName}"); } } diff --git a/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdExecutor.cs b/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdExecutor.cs index 0ee10a2e34..e8e8a3ef42 100644 --- a/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdExecutor.cs @@ -243,7 +243,7 @@ protected ISystemManagement SystemManagement } /// - /// Applies the configuration specificed to the parameters of the profile + /// Applies the configuration specified to the parameters of the profile /// workload action. /// /// Provides context information to include with telemetry events. @@ -515,11 +515,11 @@ protected virtual string GetTestFile(string mountPoint) } /// - /// Returns the name of the test files seperated by whitespace given a mount point. + /// Returns the name of the test files separated by whitespace given a mount point. /// /// A mount point to the disk under test. /// - /// The full path to the test files seperated by whitespace. + /// The full path to the test files separated by whitespace. /// protected virtual string GetTestFiles(string mountPoint) { diff --git a/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdMetricsParser.cs index a67abe6426..c61eb40b63 100644 --- a/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/DiskSpd/DiskSpdMetricsParser.cs @@ -24,7 +24,7 @@ public class DiskSpdMetricsParser : MetricsParser private static readonly Regex DiskSpdSectionDelimiter = new Regex(@"(\n)(\s)*(\n)", RegexOptions.ExplicitCapture); /// - /// Separate the column values by '|' and trim surrouding spaces.. + /// Separate the column values by '|' and trim surrounding spaces.. /// private static readonly Regex DiskSpdDataTableDelimiter = new Regex(@"( )*(\|)( )*", RegexOptions.ExplicitCapture); diff --git a/src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleClientExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleClientExecutor.cs index a5a9166345..c6d4755942 100644 --- a/src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleClientExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleClientExecutor.cs @@ -78,7 +78,7 @@ public int ServerPort /// /// It is common to use local member variables or properties to keep track of the names of - /// workload binaries/executables. Dependending upon the OS platform (Linux vs. Windows) we are on + /// workload binaries/executables. Depending upon the OS platform (Linux vs. Windows) we are on /// the names of the binaries might be different. /// protected string WorkloadExecutablePath { get; set; } diff --git a/src/VirtualClient/VirtualClient.Actions/Examples/ExampleWorkloadExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Examples/ExampleWorkloadExecutor.cs index b8392f79d5..0e329a1344 100644 --- a/src/VirtualClient/VirtualClient.Actions/Examples/ExampleWorkloadExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Examples/ExampleWorkloadExecutor.cs @@ -164,7 +164,7 @@ public int ExampleParameter2 /// /// It is common to use local member variables or properties to keep track of the names of - /// workload binaries/executables. Dependending upon the OS platform (Linux vs. Windows) we are on + /// workload binaries/executables. Depending upon the OS platform (Linux vs. Windows) we are on /// the names of the binaries might be different. /// protected string WorkloadExecutablePath { get; set; } diff --git a/src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs b/src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs index 25395a181b..ef2183173f 100644 --- a/src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs @@ -435,7 +435,7 @@ protected virtual IEnumerable CreateWorkloadProcesses(strin } /// - /// Applies the configuration specificed to the parameters of the profile + /// Applies the configuration specified to the parameters of the profile /// workload action. /// /// Provides context information to include with telemetry events. @@ -544,11 +544,11 @@ protected async Task IsDiskFillCompleteAsync(CancellationToken cancellatio } /// - /// Returns the name of the test files seperated by whitespace given a mount point. + /// Returns the name of the test files separated by whitespace given a mount point. /// /// A mount point to the disk under test. /// - /// The full path to the test files seperated by whitespace. + /// The full path to the test files separated by whitespace. /// protected virtual string GetTestFiles(string mountPoint) { @@ -957,7 +957,7 @@ private IEnumerable CreateSingleProcessAggregatedWorkloadPr string[] testFiles = disks.Select(disk => this.GetTestDevicePath(disk)).ToArray(); // e.g. - // The command line defines the specifics of each indvidual job. The job file defines each job-per-disk. + // The command line defines the specifics of each individual job. The job file defines each job-per-disk. // // --size={FileSize} --numjobs=16 --rw=randwrite --bs=4k --iodepth=32 --ioengine=libaio --direct=1 --ramp_time=30 --runtime=600 --time_based // --overwrite=1 --thread --group_reporting --output-format=json /home/user/virtualclient.1.0.0/content/linux-arm64/temp/2d2218cd-4862-458e-bc91-c332a6d6aae9.fio diff --git a/src/VirtualClient/VirtualClient.Actions/HPCG/HpcgExecutor.cs b/src/VirtualClient/VirtualClient.Actions/HPCG/HpcgExecutor.cs index a2aa155e4f..9dec8d6a94 100644 --- a/src/VirtualClient/VirtualClient.Actions/HPCG/HpcgExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/HPCG/HpcgExecutor.cs @@ -214,8 +214,8 @@ private async Task WriteHpcgDatFileAsync(CancellationToken cancellationToken) long totalMemoryKiloBytes = memoryInfo.TotalMemory; // The standard of the HPCG size is to set it to consume 25% of the total memory. - // The memory the benchmark uses is propotional to the 3rd-power of the size. - // In another word, the size is propotional to the cubic root of total memory. + // The memory the benchmark uses is proportional to the 3rd-power of the size. + // In another word, the size is proportional to the cubic root of total memory. // 200 * 200 * 200 = 8M size cost about 104GB of memory. Each size cost 3.4KB // 160 * 160 * 160 = 4M size cost about 52GB of memory. Each size cost 3.4KB // The size needs to be dividable by 8. So it needs the /8 inside toint() and *8 outside. diff --git a/src/VirtualClient/VirtualClient.Actions/HPLinpack/HPLinpackExecutor.cs b/src/VirtualClient/VirtualClient.Actions/HPLinpack/HPLinpackExecutor.cs index a50623ae7b..01a824aea9 100644 --- a/src/VirtualClient/VirtualClient.Actions/HPLinpack/HPLinpackExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/HPLinpack/HPLinpackExecutor.cs @@ -64,7 +64,7 @@ public string ProblemSizeN { // HPLinpack problemSize could take 80% of total available memory for optimal performance.-> xKiloByte * 0.8 // Number of double precision(8 bytes) elements that can fit the available memory -> ( xKiloByte * 0.8 ) / 8 -> ( xByte * 1024 * 0.8 ) /8 - // The memory the benchmark uses is propotional to the 2nd-power of the size. -> sqrt( ( xByte * 1024 * 0.8 ) /8) + // The memory the benchmark uses is proportional to the 2nd-power of the size. -> sqrt( ( xByte * 1024 * 0.8 ) /8) int size = Convert.ToInt32(Math.Sqrt(this.totalMemoryKiloBytes * 1024 * 0.8 / 8)); return this.Parameters.GetValue(nameof(this.ProblemSizeN), size); } diff --git a/src/VirtualClient/VirtualClient.Actions/LMbench/LMbenchMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/LMbench/LMbenchMetricsParser.cs index 40c6039706..712e858d5d 100644 --- a/src/VirtualClient/VirtualClient.Actions/LMbench/LMbenchMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/LMbench/LMbenchMetricsParser.cs @@ -96,7 +96,7 @@ public override IList Parse() this.Preprocess(); this.Sections = TextParsingExtensions.Sectionize(this.PreprocessedText, LMbenchMetricsParser.LMbenchSectionDelimiter); - // LMbench sometimes skipp those four measurements if it can't figure out the OS. Those tables are made optional. + // LMbench sometimes skip those four measurements if it can't figure out the OS. Those tables are made optional. this.ParseProcessorTimes(); this.ParseBasicInt(); this.ParseBasicFloat(); @@ -104,7 +104,7 @@ public override IList Parse() this.ParseContextSwitching(); this.ParseCommunicationLatency(); - this.ParseCommnunicationBandwidth(); + this.ParseCommunicationBandwidth(); this.ParseFileVMLatency(); this.ParseMemoryLatency(); @@ -480,7 +480,7 @@ private void ParseFileVMLatency() this.FileVmLatency.ReplaceEmptyCell(replacement: null); } - private void ParseCommnunicationBandwidth() + private void ParseCommunicationBandwidth() { string tableName = "*Local* Communication bandwidths in MB/s - bigger is better"; IList columnNames = new List diff --git a/src/VirtualClient/VirtualClient.Actions/MLPerf/MLPerfExecutor.cs b/src/VirtualClient/VirtualClient.Actions/MLPerf/MLPerfExecutor.cs index 8fb9c21376..af3e5e2840 100644 --- a/src/VirtualClient/VirtualClient.Actions/MLPerf/MLPerfExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/MLPerf/MLPerfExecutor.cs @@ -286,7 +286,7 @@ protected async Task CreateScratchSpace(CancellationToken cancellationToken) /// protected string GetContainerName() { - // Update this function to accomodate other architectures + // Update this function to accommodate other architectures if (this.Platform == PlatformID.Unix && this.CpuArchitecture == Architecture.X64) { return $"mlperf-inference-{this.Username}-x86_64"; diff --git a/src/VirtualClient/VirtualClient.Actions/MLPerfTraining/MLPerfTrainingExecutor.cs b/src/VirtualClient/VirtualClient.Actions/MLPerfTraining/MLPerfTrainingExecutor.cs index fa2c5a6463..c458f1b815 100644 --- a/src/VirtualClient/VirtualClient.Actions/MLPerfTraining/MLPerfTrainingExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/MLPerfTraining/MLPerfTrainingExecutor.cs @@ -179,7 +179,7 @@ protected async Task SetupDocker(EventContext telemetryContext, CancellationToke /// protected string GetContainerName() { - // Update this function to accomodate other architectures + // Update this function to accommodate other architectures if (this.Platform == PlatformID.Unix && this.CpuArchitecture == Architecture.X64) { return $"mlperf-training-{this.Username}-x86_64:{this.ContainerName}"; diff --git a/src/VirtualClient/VirtualClient.Actions/Memcached/MemcachedExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Memcached/MemcachedExecutor.cs index 533d84d419..4380700534 100644 --- a/src/VirtualClient/VirtualClient.Actions/Memcached/MemcachedExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Memcached/MemcachedExecutor.cs @@ -67,7 +67,7 @@ public string Username } /// - /// The Memtier benchmark will return an exit code of 130 when it is interupted while + /// The Memtier benchmark will return an exit code of 130 when it is interrupted while /// trying to write to standard output. This happens when Ctrl-C is used for example. /// We handle this error for this reason. /// diff --git a/src/VirtualClient/VirtualClient.Actions/Memtier/ServerState.cs b/src/VirtualClient/VirtualClient.Actions/Memtier/ServerState.cs index 2e1b56c8a5..001ea76423 100644 --- a/src/VirtualClient/VirtualClient.Actions/Memtier/ServerState.cs +++ b/src/VirtualClient/VirtualClient.Actions/Memtier/ServerState.cs @@ -50,7 +50,7 @@ public IEnumerable Ports // e.g. // 6379:0,,,6380:1,,,6381:2 // - // For some servers, a signle instance may be bound to all logical processors + // For some servers, a single instance may be bound to all logical processors // // e.g. // 6379:0,1,2,3,4,5,6,7 diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpClientExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpClientExecutor.cs index d02bb42e66..a367208784 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpClientExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpClientExecutor.cs @@ -9,7 +9,7 @@ namespace VirtualClient.Actions.NetworkPerformance using VirtualClient.Contracts; /// - /// NTttcp(Test Bandwith and Throughput) Tool Client Executor. + /// NTttcp(Test Bandwidth and Throughput) Tool Client Executor. /// public class NTttcpClientExecutor : NTttcpExecutor { diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs index 242eae9a69..f23b943860 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs @@ -19,7 +19,7 @@ namespace VirtualClient.Actions.NetworkPerformance using VirtualClient.Contracts.Metadata; /// - /// NTttcp(Test Bandwith and Throughput) Tool Client Executor. + /// NTttcp(Test Bandwidth and Throughput) Tool Client Executor. /// public class NTttcpExecutor : NetworkingWorkloadToolExecutor { diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpMetricsParser.cs index b0f0d7c913..56bdb5da82 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpMetricsParser.cs @@ -389,7 +389,7 @@ public class NTttcpParameters public int SendSocketBuffer { get; set; } /// - /// The recieve socket buffer option. + /// The receive socket buffer option. /// [XmlElement("recv_socket_buff")] public int ReceiveSocketBuffer { get; set; } diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpServerExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpServerExecutor.cs index 24e9f242c7..06ca72b557 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpServerExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpServerExecutor.cs @@ -9,7 +9,7 @@ namespace VirtualClient.Actions.NetworkPerformance using VirtualClient.Contracts; /// - /// NTttcp(Test Bandwith and Throughput) Tool Server Executor. + /// NTttcp(Test Bandwidth and Throughput) Tool Server Executor. /// public class NTttcpServerExecutor : NTttcpExecutor { diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NetworkingWorkloadExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NetworkingWorkloadExecutor.cs index 6e6ce8183d..0fed473479 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NetworkingWorkloadExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NetworkingWorkloadExecutor.cs @@ -562,7 +562,7 @@ protected override void Dispose(bool disposing) } /// - /// Intialize Networking workload. + /// Initialize Networking workload. /// protected override async Task InitializeAsync(EventContext telemetryContext, CancellationToken cancellationToken) { @@ -903,7 +903,7 @@ await this.ExecuteClientToolAsync(NetworkingWorkloadTool.SockPerf, telemetryCont /// /// Execute the tool on client side,Following the steps below: /// 1. Poll for the server to be online. - /// 2. Send Notification to server to start instance of the specificed tool. + /// 2. Send Notification to server to start instance of the specified tool. /// 3. Execute client side of the tool. /// private Task ExecuteClientToolAsync(NetworkingWorkloadTool toolName, EventContext telemetryContext, CancellationToken cancellationToken) diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfMetricsParser.cs index 248f29e5d9..3d7e63b379 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfMetricsParser.cs @@ -18,7 +18,7 @@ public class SockPerfMetricsParser : MetricsParser { private static readonly Regex ObservatiosnExpression = new Regex(@"^sockperf.* (\d+) observations.*", RegexOptions.Compiled | RegexOptions.Multiline); private static readonly int HeaderCount = 20; - private static readonly string Seperator = "------------------------------"; + private static readonly string Separator = "------------------------------"; private static readonly string ObservationsHeader = "packet, txTime(sec), rxTime(sec), rtt(usec)"; private double confidenceLevel; @@ -69,7 +69,7 @@ private static List GetPacketsLatency(string preprocessedText) headerCount--; - if (headerCount == 0 && line.Trim() != Seperator) + if (headerCount == 0 && line.Trim() != Separator) { throw new WorkloadResultsException( "Results parsing operation failed. The Sockperf parser failed to parse the complete header.", @@ -82,7 +82,7 @@ private static List GetPacketsLatency(string preprocessedText) { continue; } - else if (line.Trim() == Seperator) + else if (line.Trim() == Separator) { break; } diff --git a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfServerExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfServerExecutor.cs index 51833271c6..44dc32e6e9 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfServerExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/SockPerf/SockPerfServerExecutor.cs @@ -15,7 +15,7 @@ namespace VirtualClient.Actions.NetworkPerformance using VirtualClient.Contracts; /// - /// NTttcp(Test Bandwith and Throughput) Tool Server Executor. + /// NTttcp(Test Bandwidth and Throughput) Tool Server Executor. /// [SupportedPlatforms("linux-arm64,linux-x64")] public class SockPerfServerExecutor : SockPerfExecutor diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSClientExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSClientExecutor2.cs index c1b606cc4d..a7ff0ace2c 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSClientExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSClientExecutor2.cs @@ -275,9 +275,9 @@ private async Task ResetServerAsync(EventContext telemetryContext, CancellationT ["Type"] = typeof(CPSServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - resetInstructions.Properties.Add(paramter); + resetInstructions.Properties.Add(parameter); } Item instructions = new Item(nameof(Instructions), resetInstructions); @@ -325,9 +325,9 @@ await this.ResetServerAsync(telemetryContext, cancellationToken) ["Type"] = typeof(CPSServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - startInstructions.Properties.Add(paramter); + startInstructions.Properties.Add(parameter); } Item instructions = new Item( diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSExecutor2.cs index a0d5aa88d1..4d065ce379 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/CPS/CPSExecutor2.cs @@ -122,7 +122,7 @@ protected ISystemManagement SystemManager protected IAsyncPolicy ProcessStartRetryPolicy { get; set; } /// - /// Intialize CPS. + /// Initialize CPS. /// protected override async Task InitializeAsync(EventContext telemetryContext, CancellationToken cancellationToken) { diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteClientExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteClientExecutor2.cs index 80195002de..ae343e2d1a 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteClientExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteClientExecutor2.cs @@ -152,9 +152,9 @@ private async Task ResetServerAsync(EventContext telemetryContext, CancellationT ["Type"] = typeof(LatteServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - resetInstructions.Properties.Add(paramter); + resetInstructions.Properties.Add(parameter); } Item instructions = new Item( @@ -204,9 +204,9 @@ await this.ResetServerAsync(telemetryContext, cancellationToken) ["Type"] = typeof(LatteServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - startInstructions.Properties.Add(paramter); + startInstructions.Properties.Add(parameter); } Item instructions = new Item( diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteExecutor2.cs index 2cbb552d3a..81ea746437 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/Latte/LatteExecutor2.cs @@ -121,7 +121,7 @@ public ProtocolType Protocol protected CancellationTokenSource ServerCancellationSource { get; set; } /// - /// Intialize Latte. + /// Initialize Latte. /// protected override async Task InitializeAsync(EventContext telemetryContext, CancellationToken cancellationToken) { diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpClientExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpClientExecutor2.cs index fca617007d..b995463a29 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpClientExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpClientExecutor2.cs @@ -232,9 +232,9 @@ private async Task ResetServerAsync(EventContext telemetryContext, CancellationT ["Type"] = typeof(NTttcpServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - resetInstructions.Properties.Add(paramter); + resetInstructions.Properties.Add(parameter); } Item instructions = new Item(nameof(Instructions), resetInstructions); @@ -336,9 +336,9 @@ await this.ResetServerAsync(telemetryContext, cancellationToken) ["Type"] = typeof(NTttcpServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - startInstructions.Properties.Add(paramter); + startInstructions.Properties.Add(parameter); } Item instructions = new Item( diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpExecutor2.cs index b5705b7f2f..987f58f70d 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpExecutor2.cs @@ -134,7 +134,7 @@ protected ISystemManagement SystemManager protected string Role { get; set; } /// - /// Intialize NTttcp. + /// Initialize NTttcp. /// protected override async Task InitializeAsync(EventContext telemetryContext, CancellationToken cancellationToken) { diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpMetricsParser2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpMetricsParser2.cs index 1473ab0a58..d2e5d2d093 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpMetricsParser2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/NTttcp/NTttcpMetricsParser2.cs @@ -389,7 +389,7 @@ public class NTttcpParameters public int SendSocketBuffer { get; set; } /// - /// The recieve socket buffer option. + /// The receive socket buffer option. /// [XmlElement("recv_socket_buff")] public int ReceiveSocketBuffer { get; set; } diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfClientExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfClientExecutor2.cs index d00990cdf7..768bdf368d 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfClientExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfClientExecutor2.cs @@ -182,9 +182,9 @@ private async Task ResetServerAsync(EventContext telemetryContext, CancellationT ["Type"] = typeof(SockPerfServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - resetInstructions.Properties.Add(paramter); + resetInstructions.Properties.Add(parameter); } Item instructions = new Item( @@ -233,9 +233,9 @@ await this.ResetServerAsync(telemetryContext, cancellationToken) ["Type"] = typeof(SockPerfServerExecutor2).Name }); - foreach (var paramter in this.Parameters) + foreach (var parameter in this.Parameters) { - startInstructions.Properties.Add(paramter); + startInstructions.Properties.Add(parameter); } Item instructions = new Item( diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfExecutor2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfExecutor2.cs index 9a8a4070de..19788180bb 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfExecutor2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfExecutor2.cs @@ -127,7 +127,7 @@ protected ISystemManagement SystemManager protected string Role { get; set; } /// - /// Intialize SockPerf. + /// Initialize SockPerf. /// protected override async Task InitializeAsync(EventContext telemetryContext, CancellationToken cancellationToken) { diff --git a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfMetricsParser2.cs b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfMetricsParser2.cs index 2b9e52a4f6..83ca18f5d9 100644 --- a/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfMetricsParser2.cs +++ b/src/VirtualClient/VirtualClient.Actions/Network2/NetworkingWorkload2/SockPerf/SockPerfMetricsParser2.cs @@ -19,7 +19,7 @@ public class SockPerfMetricsParser2 : MetricsParser { private static readonly Regex ObservatiosnExpression = new Regex(@"^sockperf.* (\d+) observations.*", RegexOptions.Compiled | RegexOptions.Multiline); private static readonly int HeaderCount = 20; - private static readonly string Seperator = "------------------------------"; + private static readonly string Separator = "------------------------------"; private static readonly string ObservationsHeader = "packet, txTime(sec), rxTime(sec), rtt(usec)"; private double confidenceLevel; @@ -84,7 +84,7 @@ private static List GetPacketsLatency(string preprocessedText) headerCount--; - if (headerCount == 0 && line.Trim() != Seperator) + if (headerCount == 0 && line.Trim() != Separator) { throw new WorkloadResultsException( "Results parsing operation failed. The Sockperf parser failed to parse the complete header.", @@ -97,7 +97,7 @@ private static List GetPacketsLatency(string preprocessedText) { continue; } - else if (line.Trim() == Seperator) + else if (line.Trim() == Separator) { break; } diff --git a/src/VirtualClient/VirtualClient.Actions/Prime95/Prime95Executor.cs b/src/VirtualClient/VirtualClient.Actions/Prime95/Prime95Executor.cs index a10eab5925..c433e47ac3 100644 --- a/src/VirtualClient/VirtualClient.Actions/Prime95/Prime95Executor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Prime95/Prime95Executor.cs @@ -54,7 +54,7 @@ public TimeSpan Duration } /// - /// The argument for Mininum FFTSize defined in the profile. + /// The argument for Minimum FFTSize defined in the profile. /// /// /// Smallest FFT values diff --git a/src/VirtualClient/VirtualClient.Actions/Redis/RedisExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Redis/RedisExecutor.cs index ff40a3e53f..78d5454696 100644 --- a/src/VirtualClient/VirtualClient.Actions/Redis/RedisExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Redis/RedisExecutor.cs @@ -38,7 +38,7 @@ protected RedisExecutor(IServiceCollection dependencies, IDictionary - /// The Memtier benchmark will return an exit code of 130 when it is interupted while + /// The Memtier benchmark will return an exit code of 130 when it is interrupted while /// trying to write to standard output. This happens when Ctrl-C is used for example. /// We handle this error for this reason. /// diff --git a/src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs b/src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs index bea923efa3..33455312e6 100644 --- a/src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/SPECcpu/SpecCpuExecutor.cs @@ -77,7 +77,7 @@ public bool RunPeak /// /// Base optimizing flags. - /// Recommand Default:-g -O3 -march=native + /// Recommend Default:-g -O3 -march=native /// public string BaseOptimizingFlags { @@ -89,7 +89,7 @@ public string BaseOptimizingFlags /// /// Iterations. - /// Recommand Default: 2 + /// Recommend Default: 2 /// public int Iterations { @@ -101,7 +101,7 @@ public int Iterations /// /// Peak optimizing flags. - /// Recommand Default:-g -Ofast -march=native -flto + /// Recommend Default:-g -Ofast -march=native -flto /// public string PeakOptimizingFlags { @@ -219,7 +219,7 @@ private string GetConfigurationFileName() return "vc-win-arm64.cfg"; default: - throw new NotSupportedException($"Current CPU architechture '{this.CpuArchitecture.ToString()}' is not supported for SPECcpu."); + throw new NotSupportedException($"Current CPU architecture '{this.CpuArchitecture.ToString()}' is not supported for SPECcpu."); } } diff --git a/src/VirtualClient/VirtualClient.Actions/ScriptExecutor/JsonMetricsParser.cs b/src/VirtualClient/VirtualClient.Actions/ScriptExecutor/JsonMetricsParser.cs index 2dd9d64d1a..70d2919f45 100644 --- a/src/VirtualClient/VirtualClient.Actions/ScriptExecutor/JsonMetricsParser.cs +++ b/src/VirtualClient/VirtualClient.Actions/ScriptExecutor/JsonMetricsParser.cs @@ -86,7 +86,7 @@ public override IList Parse() catch (Exception exc) { throw new WorkloadResultsException( - "Invalid JSON metrics content formatting. Failed to deserialze the Array JSON Contents into Metrics format.", exc, ErrorReason.InvalidResults); + "Invalid JSON metrics content formatting. Failed to deserialize the Array JSON Contents into Metrics format.", exc, ErrorReason.InvalidResults); } if (metrics.Any(m => string.IsNullOrWhiteSpace(m.Name))) diff --git a/src/VirtualClient/VirtualClient.Actions/StressAppTest/StressAppTestExecutor.cs b/src/VirtualClient/VirtualClient.Actions/StressAppTest/StressAppTestExecutor.cs index e69ad03487..98034d6eae 100644 --- a/src/VirtualClient/VirtualClient.Actions/StressAppTest/StressAppTestExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/StressAppTest/StressAppTestExecutor.cs @@ -149,7 +149,7 @@ protected override void Validate() throw new WorkloadException( $"Unexpected profile definition.The action in the profile does not contain the " + $"required value for'{nameof(this.CommandLine)}' arguments defined. {nameof(this.CommandLine)} should not contain a custom log file, with " + - $"-l parameter. That is being appended programatically", + $"-l parameter. That is being appended programmatically", ErrorReason.InvalidProfileDefinition); } } diff --git a/src/VirtualClient/VirtualClient.Actions/StressNg/StressNgExecutor.cs b/src/VirtualClient/VirtualClient.Actions/StressNg/StressNgExecutor.cs index 636b3d6b32..b58470cb1c 100644 --- a/src/VirtualClient/VirtualClient.Actions/StressNg/StressNgExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/StressNg/StressNgExecutor.cs @@ -134,7 +134,7 @@ protected override void Validate() throw new WorkloadException( $"Unexpected profile definition.The action in the profile does not contain the " + $"required value for'{nameof(this.CommandLine)}' arguments defined. {nameof(this.CommandLine)} should not contain a custom log file, with " + - $"--yaml or -Y parameter. That is being appended programatically", + $"--yaml or -Y parameter. That is being appended programmatically", ErrorReason.InvalidProfileDefinition); } } diff --git a/src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs b/src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs index f85650541e..3d385a6713 100644 --- a/src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs +++ b/src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs @@ -177,7 +177,7 @@ public string Workload } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public string Action { @@ -237,7 +237,7 @@ public static int GetRecordCount(ISystemManagement systemManagement, string data CpuInfo cpuInfo = systemManagement.GetCpuInfoAsync(CancellationToken.None).GetAwaiter().GetResult(); int coreCount = cpuInfo.LogicalProcessorCount; - // record count calcuated for default use is 10^n where n = core count + // record count calculated for default use is 10^n where n = core count // for the in memory scenario, it is n+2 int recordCountExponent = (databaseScenario != SysbenchScenario.InMemory) @@ -390,7 +390,7 @@ protected async Task InitializeExecutablesAsync(EventContext telemetryContext, C } /// - /// Add metrics to telemtry. + /// Add metrics to telemetry. /// /// /// diff --git a/src/VirtualClient/VirtualClient.Common/ConcurrentBuffer.cs b/src/VirtualClient/VirtualClient.Common/ConcurrentBuffer.cs index 104a9db313..d033bb5dd9 100644 --- a/src/VirtualClient/VirtualClient.Common/ConcurrentBuffer.cs +++ b/src/VirtualClient/VirtualClient.Common/ConcurrentBuffer.cs @@ -18,7 +18,7 @@ public class ConcurrentBuffer private StringBuilder underlyingStringBuilder; /// - /// Intializes a new instance of the class. + /// Initializes a new instance of the class. /// public ConcurrentBuffer() { @@ -26,7 +26,7 @@ public ConcurrentBuffer() } /// - /// Intializes a new instance of the class. + /// Initializes a new instance of the class. /// public ConcurrentBuffer(StringBuilder stringBuilder) { diff --git a/src/VirtualClient/VirtualClient.Common/Extensions/ParameterValidationExtensions.cs b/src/VirtualClient/VirtualClient.Common/Extensions/ParameterValidationExtensions.cs index f263fbac8e..bdfe27d602 100644 --- a/src/VirtualClient/VirtualClient.Common/Extensions/ParameterValidationExtensions.cs +++ b/src/VirtualClient/VirtualClient.Common/Extensions/ParameterValidationExtensions.cs @@ -66,7 +66,7 @@ public static void ThrowIfEmpty([ValidatedNotNull] this IEnumerable parame /// /// Throws an exception if the validator returns false for an object. /// - /// The type of object being valudated. + /// The type of object being validated. /// The object to validate. /// Name of the parameter. /// diff --git a/src/VirtualClient/VirtualClient.Common/IProcessProxy.cs b/src/VirtualClient/VirtualClient.Common/IProcessProxy.cs index eb847ffc7e..261916db4b 100644 --- a/src/VirtualClient/VirtualClient.Common/IProcessProxy.cs +++ b/src/VirtualClient/VirtualClient.Common/IProcessProxy.cs @@ -53,19 +53,19 @@ public interface IProcessProxy : IDisposable bool HasExited { get; } /// - /// True/false whether standard error from the underlying proces should + /// True/false whether standard error from the underlying process should /// be redirected. Note that this MUST be set before the process is started. /// bool RedirectStandardError { get; set; } /// - /// True/false whether standard output from the underlying proces should + /// True/false whether standard output from the underlying process should /// be redirected. Note that this MUST be set before the process is started. /// bool RedirectStandardInput { get; set; } /// - /// True/false whether standard output from the underlying proces should + /// True/false whether standard output from the underlying process should /// be redirected. Note that this MUST be set before the process is started. /// bool RedirectStandardOutput { get; set; } diff --git a/src/VirtualClient/VirtualClient.Common/Rest/RequestResponseExtensions.cs b/src/VirtualClient/VirtualClient.Common/Rest/RequestResponseExtensions.cs index 71a6451d3f..3c7dc6ecf7 100644 --- a/src/VirtualClient/VirtualClient.Common/Rest/RequestResponseExtensions.cs +++ b/src/VirtualClient/VirtualClient.Common/Rest/RequestResponseExtensions.cs @@ -15,7 +15,7 @@ namespace VirtualClient.Common.Rest using VirtualClient.Common.Extensions; /// - /// Collection of HttpCotent methods. + /// Collection of HttpContent methods. /// public static class RequestResponseExtensions { diff --git a/src/VirtualClient/VirtualClient.Common/Telemetry/CallContextPersistenceManager.cs b/src/VirtualClient/VirtualClient.Common/Telemetry/CallContextPersistenceManager.cs index c6895fd460..761d6b9c17 100644 --- a/src/VirtualClient/VirtualClient.Common/Telemetry/CallContextPersistenceManager.cs +++ b/src/VirtualClient/VirtualClient.Common/Telemetry/CallContextPersistenceManager.cs @@ -128,7 +128,7 @@ public Guid GetParentActivityId() } /// - /// Returns the user identitiy persisted. + /// Returns the user identity persisted. /// /// /// The user identity persisted. diff --git a/src/VirtualClient/VirtualClient.Common/Telemetry/IPersistenceManager.cs b/src/VirtualClient/VirtualClient.Common/Telemetry/IPersistenceManager.cs index e27eb056d4..40aff73a24 100644 --- a/src/VirtualClient/VirtualClient.Common/Telemetry/IPersistenceManager.cs +++ b/src/VirtualClient/VirtualClient.Common/Telemetry/IPersistenceManager.cs @@ -37,7 +37,7 @@ public interface IPersistenceManager : IDisposable Guid GetParentActivityId(); /// - /// Returns the user identitiy persisted. + /// Returns the user identity persisted. /// /// /// The user identity persisted. diff --git a/src/VirtualClient/VirtualClient.Contracts.UnitTests/DiskFiltersTests.cs b/src/VirtualClient/VirtualClient.Contracts.UnitTests/DiskFiltersTests.cs index a6a9179616..0ea37e0b59 100644 --- a/src/VirtualClient/VirtualClient.Contracts.UnitTests/DiskFiltersTests.cs +++ b/src/VirtualClient/VirtualClient.Contracts.UnitTests/DiskFiltersTests.cs @@ -107,7 +107,7 @@ public void DiskFiltersCanFilterOnBiggestDisksOnLinux() } [Test] - public void DiskFiltersCanFilterOnBiggestDisksOnLinuxForDisksWithoutVolumePartititions() + public void DiskFiltersCanFilterOnBiggestDisksOnLinuxForDisksWithoutVolumePartitions() { this.disks = this.mockFixture.CreateDisks(PlatformID.Unix, false); this.disks.ElementAt(0).Properties["size"] = 3 * 1024 * 1024; @@ -139,7 +139,7 @@ public void DiskFiltersCanFilterOnBiggestDisksOnWindows() [Test] [Ignore("We can support this in the future if we add a 'Size' property to the Disk object for Windows (e.g. DiskPart -> list disks).")] - public void DiskFiltersCanFilterOnBiggestDisksOnWindowsForDisksWithoutVolumePartititions() + public void DiskFiltersCanFilterOnBiggestDisksOnWindowsForDisksWithoutVolumePartitions() { this.disks = this.mockFixture.CreateDisks(PlatformID.Win32NT, false); this.disks.ElementAt(0).Properties["Size"] = 3 * 1024 * 1024; diff --git a/src/VirtualClient/VirtualClient.Contracts.UnitTests/PlatformSpecificsTests.cs b/src/VirtualClient/VirtualClient.Contracts.UnitTests/PlatformSpecificsTests.cs index 9bf4997f7f..6526317c46 100644 --- a/src/VirtualClient/VirtualClient.Contracts.UnitTests/PlatformSpecificsTests.cs +++ b/src/VirtualClient/VirtualClient.Contracts.UnitTests/PlatformSpecificsTests.cs @@ -487,7 +487,7 @@ public void PlatformSpecificsStandardizesPathsCorrectlyWhenUseUnixStylePathsOnly [TestCase(@"/packages/a/b/c/d", @"/packages/a/b/c", @"/packages/a/b", @"/packages/a/")] [TestCase(@"/packages2/a/b/c/d", @"/packages/a/b/c", @"/packages/a/b", @"/")] [TestCase(@"/vc/packages2/a\b/c/d", @"/vc\packages2/a/b/c", @"\vc/packages/a/b", @"/vc/")] - public void PlatformGetCommmonDirectoryCorrectlyOnLinuxSystems(string path1, string path2, string path3, string expectedPath) + public void PlatformGetCommonDirectoryCorrectlyOnLinuxSystems(string path1, string path2, string path3, string expectedPath) { PlatformSpecifics platformSpecifics = new PlatformSpecifics(PlatformID.Unix, Architecture.X64); string actualPath = platformSpecifics.GetCommonDirectory(new string[] { path1, path2, path3 }); @@ -500,7 +500,7 @@ public void PlatformGetCommmonDirectoryCorrectlyOnLinuxSystems(string path1, str [TestCase(@"A:\a\a.txt", @"A:\a\b\b.pdf", @"A:\a\b\c\c.jpg", @"A:\a\")] [TestCase(@"A:\a\a.txt", @"A:\a\b\b.pdf", @"AA:\a\b\c\c.jpg", @"")] [TestCase(@"A:\a\a.txt", @"B:\a\b.pdf", @"A:\a\c.jpg", @"")] - public void PlatformGetCommmonDirectoryCorrectlyOnWindowsSystems(string path1, string path2, string path3, string expectedPath) + public void PlatformGetCommonDirectoryCorrectlyOnWindowsSystems(string path1, string path2, string path3, string expectedPath) { PlatformSpecifics platformSpecifics = new PlatformSpecifics(PlatformID.Win32NT, Architecture.X64); string actualPath = platformSpecifics.GetCommonDirectory(new string[] { path1, path2, path3 }); diff --git a/src/VirtualClient/VirtualClient.Contracts.UnitTests/StatusCodeRegistryTests.cs b/src/VirtualClient/VirtualClient.Contracts.UnitTests/StatusCodeRegistryTests.cs index 8b36a36566..cc20cc9d1d 100644 --- a/src/VirtualClient/VirtualClient.Contracts.UnitTests/StatusCodeRegistryTests.cs +++ b/src/VirtualClient/VirtualClient.Contracts.UnitTests/StatusCodeRegistryTests.cs @@ -11,7 +11,7 @@ public class StatusCodeRegistryTests [TestCase(ErrorReason.DependencyDescriptionInvalid, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] [TestCase(ErrorReason.DuplicateExtensionsFound, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] [TestCase(ErrorReason.DuplicatePackagesFound, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] - [TestCase(ErrorReason.EnvironmentIsInsufficent, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] + [TestCase(ErrorReason.EnvironmentIsInsufficient, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] [TestCase(ErrorReason.ExtensionAssemblyInvalid, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] [TestCase(ErrorReason.InvalidOrMissingLicense, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] [TestCase(ErrorReason.InvalidProfileDefinition, StatusCodeRegistry.StatusCodeBase.ConfigurationError)] diff --git a/src/VirtualClient/VirtualClient.Contracts.UnitTests/VirtualClientComponentTests.cs b/src/VirtualClient/VirtualClient.Contracts.UnitTests/VirtualClientComponentTests.cs index 10c5ba946a..7104ca04fa 100644 --- a/src/VirtualClient/VirtualClient.Contracts.UnitTests/VirtualClientComponentTests.cs +++ b/src/VirtualClient/VirtualClient.Contracts.UnitTests/VirtualClientComponentTests.cs @@ -291,7 +291,7 @@ public void VirtualClientComponentRolesAreNotCaseSensitive_Scenario2() } [Test] - public void VirtualClientComponentReturnsTheExpectedClientInstancseFromTheEnvironmentLayoutByRole() + public void VirtualClientComponentReturnsTheExpectedClientInstanceFromTheEnvironmentLayoutByRole() { ClientInstance expectedInstance = this.mockFixture.Layout.Clients.ElementAt(1); VirtualClientComponent component = new TestVirtualClientComponent(this.mockFixture.Dependencies, this.mockFixture.Parameters); diff --git a/src/VirtualClient/VirtualClient.Contracts/CpuInfo.cs b/src/VirtualClient/VirtualClient.Contracts/CpuInfo.cs index 752365ec04..24d673e076 100644 --- a/src/VirtualClient/VirtualClient.Contracts/CpuInfo.cs +++ b/src/VirtualClient/VirtualClient.Contracts/CpuInfo.cs @@ -27,7 +27,7 @@ public class CpuInfo /// List of other information about CPU /// Maximum CPU frequency in MHz. /// Minimum CPU frequency in MHz. - /// Currrent frequency of CPU in MHz. + /// Current frequency of CPU in MHz. public CpuInfo(string name, string description, int physicalCoreCount, int logicalCoreCount, int socketCount, int numaNodeCount, bool hyperThreadingEnabled, IEnumerable caches = null, Dictionary flags = null, double maxFrequency = double.NaN, double minFrequency = double.NaN, double frequency = double.NaN) : base() { @@ -139,7 +139,7 @@ public int LogicalProcessorCountPerPhysicalCore public double MinFrequencyMHz { get; set; } = double.NaN; /// - /// Currrent frequency of CPU in MHz. + /// Current frequency of CPU in MHz. /// public double FrequencyMHz { get; set; } = double.NaN; } diff --git a/src/VirtualClient/VirtualClient.Contracts/DiskExtensions.cs b/src/VirtualClient/VirtualClient.Contracts/DiskExtensions.cs index ead774434d..26a955ee45 100644 --- a/src/VirtualClient/VirtualClient.Contracts/DiskExtensions.cs +++ b/src/VirtualClient/VirtualClient.Contracts/DiskExtensions.cs @@ -55,7 +55,7 @@ public static string GetPreferredAccessPath(this Disk disk, PlatformID platform) if (eligibleVolumes.Count() == 0) { - throw new WorkloadException($"There is no eligible volume in {disk.DevicePath} that can run IO workloads.", ErrorReason.EnvironmentIsInsufficent); + throw new WorkloadException($"There is no eligible volume in {disk.DevicePath} that can run IO workloads.", ErrorReason.EnvironmentIsInsufficient); } long biggestSize = eligibleVolumes.Max(v => v.SizeInBytes(platform)); @@ -93,7 +93,7 @@ public static string GetDefaultMountPointName(this DiskVolume volume, string pre /// /// Returns if a partition is OS partition. /// - /// Specificed volume/partition. + /// Specified volume/partition. /// True/False a volume is operating system. public static bool IsOperatingSystem(this DiskVolume volume) { diff --git a/src/VirtualClient/VirtualClient.Contracts/Enumerations.cs b/src/VirtualClient/VirtualClient.Contracts/Enumerations.cs index f706a745ce..90d453c29b 100644 --- a/src/VirtualClient/VirtualClient.Contracts/Enumerations.cs +++ b/src/VirtualClient/VirtualClient.Contracts/Enumerations.cs @@ -200,7 +200,7 @@ public enum ErrorReason : int /// The environment that the Virtual Client is executing on /// does not have sufficient resources to run. /// - EnvironmentIsInsufficent = 508, + EnvironmentIsInsufficient = 508, /// /// One or more instructions provided are invalid/incorrect. @@ -524,7 +524,7 @@ public enum InstructionsType public enum LinuxDistribution { /// - /// Unkwown distribution. + /// Unknown distribution. /// Unknown, diff --git a/src/VirtualClient/VirtualClient.Contracts/Exceptions.cs b/src/VirtualClient/VirtualClient.Contracts/Exceptions.cs index 92669b086e..6cd16c2b90 100644 --- a/src/VirtualClient/VirtualClient.Contracts/Exceptions.cs +++ b/src/VirtualClient/VirtualClient.Contracts/Exceptions.cs @@ -544,7 +544,7 @@ public StartupException(string message, Exception innerException, ErrorReason re } /// - /// Represents the base exception for errors that occurr in relation to the + /// Represents the base exception for errors that occur in relation to the /// experiment schema. /// [Serializable] diff --git a/src/VirtualClient/VirtualClient.Contracts/Extensions/EnvironmentLayoutExtensions.cs b/src/VirtualClient/VirtualClient.Contracts/Extensions/EnvironmentLayoutExtensions.cs index 813be37aea..fab6c96d36 100644 --- a/src/VirtualClient/VirtualClient.Contracts/Extensions/EnvironmentLayoutExtensions.cs +++ b/src/VirtualClient/VirtualClient.Contracts/Extensions/EnvironmentLayoutExtensions.cs @@ -13,7 +13,7 @@ namespace VirtualClient.Contracts public static class EnvironmentLayoutExtensions { /// - /// Returns the client instance from the layout that matches with the local sytem (i.e. matching IP address) + /// Returns the client instance from the layout that matches with the local system (i.e. matching IP address) /// or null if one is not found. /// /// The ID of the Virtual Client agent/instance. diff --git a/src/VirtualClient/VirtualClient.Contracts/Extensions/MetricExtensions.cs b/src/VirtualClient/VirtualClient.Contracts/Extensions/MetricExtensions.cs index 402022c4b5..9b76ca38a1 100644 --- a/src/VirtualClient/VirtualClient.Contracts/Extensions/MetricExtensions.cs +++ b/src/VirtualClient/VirtualClient.Contracts/Extensions/MetricExtensions.cs @@ -124,7 +124,7 @@ public static void LogConsole(this IEnumerable metrics, string scenario, } /// - /// Data table with formated column width. + /// Data table with formatted column width. /// /// Input data table. private static void LogConsole(DataTable dataTable) diff --git a/src/VirtualClient/VirtualClient.Contracts/LinuxDistributionInfo.cs b/src/VirtualClient/VirtualClient.Contracts/LinuxDistributionInfo.cs index 865393f5fd..5dbf1a9c1e 100644 --- a/src/VirtualClient/VirtualClient.Contracts/LinuxDistributionInfo.cs +++ b/src/VirtualClient/VirtualClient.Contracts/LinuxDistributionInfo.cs @@ -4,7 +4,7 @@ namespace VirtualClient.Contracts { /// - /// Contract class for describing Linux Distribution infomation. + /// Contract class for describing Linux Distribution information. /// public class LinuxDistributionInfo { diff --git a/src/VirtualClient/VirtualClient.Contracts/MetricUnit.cs b/src/VirtualClient/VirtualClient.Contracts/MetricUnit.cs index cb933b1442..9f58aab17b 100644 --- a/src/VirtualClient/VirtualClient.Contracts/MetricUnit.cs +++ b/src/VirtualClient/VirtualClient.Contracts/MetricUnit.cs @@ -15,9 +15,9 @@ public class MetricUnit public const string Amps = "amps"; /// - /// Celcius + /// Celsius /// - public const string Celcius = "celcius"; + public const string Celsius = "celsius"; /// /// Petabytes diff --git a/src/VirtualClient/VirtualClient.Contracts/PlatformSpecifics.cs b/src/VirtualClient/VirtualClient.Contracts/PlatformSpecifics.cs index e9e96fb403..b965e9c4fc 100644 --- a/src/VirtualClient/VirtualClient.Contracts/PlatformSpecifics.cs +++ b/src/VirtualClient/VirtualClient.Contracts/PlatformSpecifics.cs @@ -367,7 +367,7 @@ public static void ThrowIfNotSupported(Architecture architecture) /// /// Returns true if the command parts can be determined and outputs the parts. /// - /// The full comamnd and arguments (e.g. sudo lshw -c disk). + /// The full command and arguments (e.g. sudo lshw -c disk). /// The command to execute. /// The arguments to pass to the command. public static bool TryGetCommandParts(string fullCommand, out string command, out string commandArguments) @@ -546,7 +546,7 @@ public string GetCommonDirectory(params string[] filePaths) List allPaths = filePaths.Select(p => this.StandardizePath(p)).ToList(); // Iterate through first string from 0 to min length of all strings - // Take while all path share charaters at index. + // Take while all path share characters at index. string commonPrefix = new string( allPaths.First().Substring(0, allPaths.Min(s => s.Length)) .TakeWhile((c, i) => allPaths.All(p => p[i] == c)).ToArray()); diff --git a/src/VirtualClient/VirtualClient.Contracts/StatusCodeRegistry.cs b/src/VirtualClient/VirtualClient.Contracts/StatusCodeRegistry.cs index 735ad3f63e..771c59eb5e 100644 --- a/src/VirtualClient/VirtualClient.Contracts/StatusCodeRegistry.cs +++ b/src/VirtualClient/VirtualClient.Contracts/StatusCodeRegistry.cs @@ -70,7 +70,7 @@ public static int GetStatusCode(int exitCode) case (int)ErrorReason.DependencyDescriptionInvalid: case (int)ErrorReason.DuplicateExtensionsFound: case (int)ErrorReason.DuplicatePackagesFound: - case (int)ErrorReason.EnvironmentIsInsufficent: + case (int)ErrorReason.EnvironmentIsInsufficient: case (int)ErrorReason.ExtensionAssemblyInvalid: case (int)ErrorReason.InvalidOrMissingLicense: case (int)ErrorReason.InvalidProfileDefinition: diff --git a/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponent.cs b/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponent.cs index f4028be9f1..48640a2d96 100644 --- a/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponent.cs +++ b/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponent.cs @@ -700,7 +700,7 @@ public async Task EvaluateParametersAsync(CancellationToken cancellationToken, b } /// - /// When overriden in a derived class, executes the component logic. + /// When overridden in a derived class, executes the component logic. /// public async Task ExecuteAsync(CancellationToken cancellationToken) { @@ -840,7 +840,7 @@ protected virtual void Dispose(bool disposing) } /// - /// When overriden in a derived class, executes the component logic. + /// When overridden in a derived class, executes the component logic. /// /// Provides context information that will be captured with telemetry events. /// A token that can be used to cancel the operation. diff --git a/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponentExtensions.cs b/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponentExtensions.cs index 64173ddfdc..a74856595c 100644 --- a/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponentExtensions.cs +++ b/src/VirtualClient/VirtualClient.Contracts/VirtualClientComponentExtensions.cs @@ -475,7 +475,7 @@ public static void ThrowIfRoleNotSupported(this VirtualClientComponent component } /// - /// Verifies an enviroment layout is defined and throws an exception if not. + /// Verifies an environment layout is defined and throws an exception if not. /// public static void ThrowIfLayoutNotDefined(this VirtualClientComponent component) { diff --git a/src/VirtualClient/VirtualClient.Core/ApiClientExtensions.cs b/src/VirtualClient/VirtualClient.Core/ApiClientExtensions.cs index 397364c8ff..5bdfe41f5a 100644 --- a/src/VirtualClient/VirtualClient.Core/ApiClientExtensions.cs +++ b/src/VirtualClient/VirtualClient.Core/ApiClientExtensions.cs @@ -32,7 +32,7 @@ public static class ApiClientExtensions /// /// The data type of the object to which the response content will be deserialized. /// Http response message. - /// Json serailized object from content. + /// Json serialized object from content. public static async Task FromContentAsync(this HttpResponseMessage response) { string responseContent = await response.Content.ReadAsStringAsync().ConfigureAwait(false); diff --git a/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLogger.cs b/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLogger.cs index 94dbd886cf..f49fddc4fe 100644 --- a/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLogger.cs +++ b/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLogger.cs @@ -32,7 +32,7 @@ public class EventHubTelemetryLogger : ILogger, IFlushableChannel private static AssemblyName executingAssembly = Assembly.GetEntryAssembly().GetName(); private JsonSerializerSettings jsonSerializationSettings; private EventHubTelemetryChannel underlyingTelemetryChannel; - private LogLevel minumumLogLevel; + private LogLevel minimumLogLevel; /// /// Initializes a new instance of the class. @@ -43,7 +43,7 @@ public EventHubTelemetryLogger(EventHubTelemetryChannel channel, LogLevel level) { channel.ThrowIfNull(nameof(channel)); this.underlyingTelemetryChannel = channel; - this.minumumLogLevel = level; + this.minimumLogLevel = level; this.jsonSerializationSettings = new JsonSerializerSettings { @@ -99,7 +99,7 @@ public void Flush(TimeSpan? timeout = null) /// public bool IsEnabled(LogLevel logLevel) { - return logLevel >= this.minumumLogLevel; + return logLevel >= this.minimumLogLevel; } /// diff --git a/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLoggerProvider.cs b/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLoggerProvider.cs index 24ab0c2efe..e12d581259 100644 --- a/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLoggerProvider.cs +++ b/src/VirtualClient/VirtualClient.Core/Logging/EventHubTelemetryLoggerProvider.cs @@ -17,7 +17,7 @@ namespace VirtualClient.Logging public sealed class EventHubTelemetryLoggerProvider : ILoggerProvider { private EventHubTelemetryChannel telemetryChannel; - private LogLevel minumumLogLevel; + private LogLevel minimumLogLevel; /// /// Initializes a new instance of the class. @@ -30,7 +30,7 @@ public EventHubTelemetryLoggerProvider(EventHubTelemetryChannel channel, LogLeve { channel.ThrowIfNull(nameof(channel)); this.telemetryChannel = channel; - this.minumumLogLevel = level; + this.minimumLogLevel = level; } /// @@ -44,7 +44,7 @@ public EventHubTelemetryLoggerProvider(EventHubTelemetryChannel channel, LogLeve /// public ILogger CreateLogger(string categoryName) { - return new EventHubTelemetryLogger(this.telemetryChannel, this.minumumLogLevel); + return new EventHubTelemetryLogger(this.telemetryChannel, this.minimumLogLevel); } /// diff --git a/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLogger.cs b/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLogger.cs index 979d90ad6b..c30c83c209 100644 --- a/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLogger.cs +++ b/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLogger.cs @@ -31,7 +31,7 @@ public class SerilogFileLogger : ILogger }; private Logger logger; - private LogLevel minumumLogLevel; + private LogLevel minimumLogLevel; /// /// Initializes a new instance of the class. @@ -41,7 +41,7 @@ public class SerilogFileLogger : ILogger public SerilogFileLogger(Logger logger, LogLevel level) { this.logger = logger; - this.minumumLogLevel = level; + this.minimumLogLevel = level; } /// @@ -53,7 +53,7 @@ public IDisposable BeginScope(TState state) /// public bool IsEnabled(LogLevel logLevel) { - return logLevel >= this.minumumLogLevel; + return logLevel >= this.minimumLogLevel; } /// diff --git a/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLoggerProvider.cs b/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLoggerProvider.cs index a4301e5cbf..3187316a22 100644 --- a/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLoggerProvider.cs +++ b/src/VirtualClient/VirtualClient.Core/Logging/SerilogFileLoggerProvider.cs @@ -20,7 +20,7 @@ namespace VirtualClient.Logging public sealed class SerilogFileLoggerProvider : ILoggerProvider, IDisposable { private LoggerConfiguration configuration; - private LogLevel minumumLogLevel; + private LogLevel minimumLogLevel; private IList disposables; private bool disposed; @@ -36,7 +36,7 @@ public SerilogFileLoggerProvider(LoggerConfiguration configuration, LogLevel lev { configuration.ThrowIfNull(nameof(configuration)); this.configuration = configuration; - this.minumumLogLevel = level; + this.minimumLogLevel = level; this.disposables = new List(); } @@ -53,7 +53,7 @@ public ILogger CreateLogger(string categoryName) { Serilog.Core.Logger logger = this.configuration.CreateLogger(); this.disposables.Add(logger); - return new SerilogFileLogger(logger, this.minumumLogLevel); + return new SerilogFileLogger(logger, this.minimumLogLevel); } /// diff --git a/src/VirtualClient/VirtualClient.Core/PerformanceTracker.cs b/src/VirtualClient/VirtualClient.Core/PerformanceTracker.cs index c8d7e2d686..21f5e3ec4a 100644 --- a/src/VirtualClient/VirtualClient.Core/PerformanceTracker.cs +++ b/src/VirtualClient/VirtualClient.Core/PerformanceTracker.cs @@ -101,7 +101,7 @@ public Task BeginTrackingAsync(TimeSpan monitorInterval, TimeSpan snapshotInterv { // This type of exception will happen if the cancellation token is cancelled // in the Task.Delay() call above. We don't want to surface this as an exception - // becuase it is entirely expected. + // because it is entirely expected. } catch (Exception exc) { @@ -147,7 +147,7 @@ public Task BeginTrackingAsync(TimeSpan monitorInterval, TimeSpan snapshotInterv { // This type of exception will happen if the cancellation token is cancelled // in the Task.Delay() call above. We don't want to surface this as an exception - // becuase it is entirely expected. + // because it is entirely expected. } catch (Exception exc) { diff --git a/src/VirtualClient/VirtualClient.Core/ProfileExpressionEvaluator.cs b/src/VirtualClient/VirtualClient.Core/ProfileExpressionEvaluator.cs index 65edb7a5e4..bcb1d169c6 100644 --- a/src/VirtualClient/VirtualClient.Core/ProfileExpressionEvaluator.cs +++ b/src/VirtualClient/VirtualClient.Core/ProfileExpressionEvaluator.cs @@ -305,7 +305,7 @@ public class ProfileExpressionEvaluator : IExpressionEvaluator if (scriptFolderPath == null) { throw new DependencyException( - $"Cannot evaluate expression {{ScriptPath:{match.Value}}}. A scipt with the name '{match.Value}' does not " + + $"Cannot evaluate expression {{ScriptPath:{match.Value}}}. A script with the name '{match.Value}' does not " + $"exist on system or is not registered with Virtual Client.", ErrorReason.DependencyNotFound); } @@ -578,12 +578,12 @@ public class ProfileExpressionEvaluator : IExpressionEvaluator ////// Expression: {calculate(512 > 2)} ////// Expression: {calculate(512 != {LogicalCoreCount})} ////// **IMPORTANT** - ////// This expression evaluation MUST come last after arthematic caluculation evaluators. + ////// This expression evaluation MUST come last after arthematic calculation evaluators. ////new Func, string, Task>(async (dependencies, parameters, expression) => ////{ //// bool isMatched = false; //// string evaluatedExpression = expression; - //// MatchCollection matches = ProfileExpressionEvaluator.CalculateComparisionExpression.Matches(expression); + //// MatchCollection matches = ProfileExpressionEvaluator.CalculateComparisonExpression.Matches(expression); //// if (matches?.Any() == true) //// { @@ -606,7 +606,7 @@ public class ProfileExpressionEvaluator : IExpressionEvaluator ////// Expression: {calculate({IsTLSEnabled} ? "Yes" : "No")} ////// Expression: {calculate(calculate(512 == 2) ? "Yes" : "No")} ////// **IMPORTANT** - ////// This expression evaluation MUST come last after arthematic/logical/comparative caluculation evaluators. + ////// This expression evaluation MUST come last after arthematic/logical/comparative calculation evaluators. ////new Func, string, Task>(async (dependencies, parameters, expression) => ////{ //// bool isMatched = false; @@ -647,7 +647,7 @@ public class ProfileExpressionEvaluator : IExpressionEvaluator // Expression: {calculate(1.00:00:00 + 00:00:10)} // // **IMPORTANT** - // This expression evaluation MUST come last after ALL other expression evaluators, before numerical arithmentic calculations. + // This expression evaluation MUST come last after ALL other expression evaluators, before numerical arithmetic calculations. new Func, string, Task>((dependencies, parameters, expression) => { bool isMatched = false; diff --git a/src/VirtualClient/VirtualClient.Core/ProfileTiming.cs b/src/VirtualClient/VirtualClient.Core/ProfileTiming.cs index 06391c81d4..b07800f077 100644 --- a/src/VirtualClient/VirtualClient.Core/ProfileTiming.cs +++ b/src/VirtualClient/VirtualClient.Core/ProfileTiming.cs @@ -12,7 +12,7 @@ namespace VirtualClient /// Represents different types of runtime timeout concepts in the Virtual Client. /// /// - /// No Timeout - User does not supply a timeout at all on the command line. The application will run until explicity terminated. + /// No Timeout - User does not supply a timeout at all on the command line. The application will run until explicitly terminated. /// /// /// Explicit Timeout - User supplies a timeout on the command line (e.g. --timeout=1440). The application will exit at that specific time. diff --git a/src/VirtualClient/VirtualClient.Core/SystemManagement.cs b/src/VirtualClient/VirtualClient.Core/SystemManagement.cs index dc63c471da..4c7c2b4b28 100644 --- a/src/VirtualClient/VirtualClient.Core/SystemManagement.cs +++ b/src/VirtualClient/VirtualClient.Core/SystemManagement.cs @@ -223,7 +223,7 @@ public bool IsLocalIPAddress(string ipAddress) /// /// Overwrite the default of 260 char in windows file path length to 32,767. /// https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry - /// Does not throw if doesn't have priviledge + /// Does not throw if doesn't have privilege /// public void EnableLongPathInWindows() { @@ -241,7 +241,7 @@ public void EnableLongPathInWindows() } catch { - // Does not throw if missing admin priviledge + // Does not throw if missing admin privilege } } diff --git a/src/VirtualClient/VirtualClient.Core/WindowsPerformanceCounter.cs b/src/VirtualClient/VirtualClient.Core/WindowsPerformanceCounter.cs index 6fd89cebce..a374bd50a1 100644 --- a/src/VirtualClient/VirtualClient.Core/WindowsPerformanceCounter.cs +++ b/src/VirtualClient/VirtualClient.Core/WindowsPerformanceCounter.cs @@ -26,7 +26,7 @@ public class WindowsPerformanceCounter : IPerformanceMetric, IDisposable private bool disposed; /// - /// Intialize a new instance of the class. + /// Initialize a new instance of the class. /// /// The performance counter category. /// The capture strategy to use over time while capturing performance values. @@ -54,7 +54,7 @@ public WindowsPerformanceCounter(PerformanceCounter counter, CaptureStrategy cap } /// - /// Intialize a new instance of the class. + /// Initialize a new instance of the class. /// /// The performance counter category. /// The performance counter name. @@ -102,7 +102,7 @@ public WindowsPerformanceCounter(string counterCategory, string counterName, str } /// - /// Intialize a new instance of the class. + /// Initialize a new instance of the class. /// /// The performance counter category. /// The performance counter name. diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/CUDAAndNvidiaGPUDriverInstallationTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/CUDAAndNvidiaGPUDriverInstallationTests.cs index d8f33dbe2f..c75bfc4a70 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/CUDAAndNvidiaGPUDriverInstallationTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/CUDAAndNvidiaGPUDriverInstallationTests.cs @@ -129,7 +129,7 @@ public void CUDAAndNvidiaGPUDriverInstallationDependencySurfacesExceptionWhenPro } [Test] - public async Task CUDAAndNvidiaGPUDriverInstallationDependencyExecutesCorrectInsatllerCommandOnWindows() + public async Task CUDAAndNvidiaGPUDriverInstallationDependencyExecutesCorrectInstallerCommandOnWindows() { this.SetupDefaultMockBehavior(PlatformID.Win32NT); this.fixture.Parameters["packageName"] = "NvidiaDrivers"; diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/Packaging/LinuxPackageInstallationTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/Packaging/LinuxPackageInstallationTests.cs index e24e66027e..1299c683ef 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/Packaging/LinuxPackageInstallationTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/Packaging/LinuxPackageInstallationTests.cs @@ -35,7 +35,7 @@ public void SetupTest() } [Test] - public async Task LinuxPackageInstallationInstantiateCorrectAptInstalltionUbuntuSimpleCase() + public async Task LinuxPackageInstallationInstantiateCorrectAptInstallationUbuntuSimpleCase() { LinuxDistributionInfo mockInfo = new LinuxDistributionInfo() { @@ -108,7 +108,7 @@ public async Task LinuxPackageInstallationDoesNotInstallIfNoPackageIsApplicable( } [Test] - public async Task LinuxPackageInstallationInstantiateCorrectAptInstalltionUbuntuComplexCase() + public async Task LinuxPackageInstallationInstantiateCorrectAptInstallationUbuntuComplexCase() { LinuxDistributionInfo mockInfo = new LinuxDistributionInfo() { @@ -141,7 +141,7 @@ public async Task LinuxPackageInstallationInstantiateCorrectAptInstalltionUbuntu } [Test] - public async Task LinuxPackageInstallationInstantiateCorrectDnfInstalltionMarinerComplexCase() + public async Task LinuxPackageInstallationInstantiateCorrectDnfInstallationMarinerComplexCase() { LinuxDistributionInfo mockInfo = new LinuxDistributionInfo() { @@ -177,7 +177,7 @@ public async Task LinuxPackageInstallationInstantiateCorrectDnfInstalltionMarine } [Test] - public async Task LinuxPackageInstallationInstantiateCorrectDnfInstalltionAwsLinuxComplexCase() + public async Task LinuxPackageInstallationInstantiateCorrectDnfInstallationAwsLinuxComplexCase() { LinuxDistributionInfo mockInfo = new LinuxDistributionInfo() { diff --git a/src/VirtualClient/VirtualClient.Dependencies/AMDGPUDriverInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/AMDGPUDriverInstallation.cs index 59bfea9913..7642411493 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/AMDGPUDriverInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/AMDGPUDriverInstallation.cs @@ -93,7 +93,7 @@ public string Username } /// - /// The AMD GPU driver installtion file for Linux + /// The AMD GPU driver installation file for Linux /// public string LinuxInstallationFile { @@ -409,4 +409,4 @@ private async Task InstallAMDGPUDriverOnV620(string driverPackagePath, EventCont } } } -} \ No newline at end of file +} diff --git a/src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs index 834eb5a90c..ce0dcf30c6 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs @@ -164,7 +164,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel break; default: - // different distro installation to be addded. + // different distro installation to be added. throw new WorkloadException( $"CUDA and Nvidia GPU driver installation is not supported by Virtual Client on the current Linux distro '{linuxDistributionInfo.LinuxDistribution}'.", ErrorReason.LinuxDistributionNotSupported); diff --git a/src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs index 8c24bab0cc..93513a2d12 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs @@ -71,7 +71,7 @@ public string CompilerVersion } /// - /// List of pacakges separated by comma that needs to be installed with cygwin (e.g. make,gcc-fortran,python3). + /// List of packages separated by comma that needs to be installed with cygwin (e.g. make,gcc-fortran,python3). /// public string CygwinPackages { @@ -110,7 +110,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel } // Ensure gcc, cc, and gfrotran versions match - bool compilerVersionsMatch = await this.ConfirmCompilerVerionsMatchAsync(telemetryContext, cancellationToken); + bool compilerVersionsMatch = await this.ConfirmCompilerVersionsMatchAsync(telemetryContext, cancellationToken); if (!compilerVersionsMatch) { throw new DependencyException("gcc, cc, and gfortran compiler versions do not match", ErrorReason.DependencyInstallationFailed); @@ -182,7 +182,7 @@ protected async Task ConfirmGccVersionInstalledAsync(CancellationToken can return (confirmedCompilers == compilersToCheck.Count); } - private async Task ConfirmCompilerVerionsMatchAsync(EventContext telemetryContext, CancellationToken cancellationToken) + private async Task ConfirmCompilerVersionsMatchAsync(EventContext telemetryContext, CancellationToken cancellationToken) { string gccVersion = await this.GetInstalledCompilerDumpVersionAsync("gcc", telemetryContext, cancellationToken); string ccVersion = await this.GetInstalledCompilerDumpVersionAsync("cc", telemetryContext, cancellationToken); diff --git a/src/VirtualClient/VirtualClient.Dependencies/DCGMIInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/DCGMIInstallation.cs index 6a2c6ac9f7..803c8c4920 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/DCGMIInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/DCGMIInstallation.cs @@ -85,7 +85,7 @@ private void ThrowIfPlatformArchitectureIsNotSupported() if (this.PlatformSpecifics.CpuArchitecture != Architecture.X64 && this.PlatformSpecifics.CpuArchitecture != Architecture.Arm64) { throw new WorkloadException( - $"DCGMI Installtion is not supported on the current platform {this.Platform} through VC." + + $"DCGMI Installation is not supported on the current platform {this.Platform} through VC." + $"Supported Platforms-Architecture include:" + $"{PlatformID.Unix}-{Architecture.X64}," + $"{PlatformID.Unix}-{Architecture.Arm64}", ErrorReason.PlatformNotSupported); @@ -94,7 +94,7 @@ private void ThrowIfPlatformArchitectureIsNotSupported() else { throw new WorkloadException( - $"DCGMI Installtion is not supported on the current platform {this.Platform} through VC." + + $"DCGMI Installation is not supported on the current platform {this.Platform} through VC." + $"Supported Platforms-Architecture include:" + $"{PlatformID.Unix}-{Architecture.X64}," + $"{PlatformID.Unix}-{Architecture.Arm64}", ErrorReason.PlatformNotSupported); diff --git a/src/VirtualClient/VirtualClient.Dependencies/DockerInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/DockerInstallation.cs index 308cc43440..59aa38040e 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/DockerInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/DockerInstallation.cs @@ -88,9 +88,9 @@ protected override async Task InitializeAsync(EventContext telemetryContext, Can break; default: - // different distro installation to be addded. + // different distro installation to be added. throw new WorkloadException( - $"Docker Installtion is not supported on the current Linux distro - {distroInfo.LinuxDistribution.ToString()}. through VC " + + $"Docker Installation is not supported on the current Linux distro - {distroInfo.LinuxDistribution.ToString()}. through VC " + $" Supported distros include:" + $" Ubuntu ", ErrorReason.LinuxDistributionNotSupported); @@ -100,7 +100,7 @@ protected override async Task InitializeAsync(EventContext telemetryContext, Can { // docker installation for windows to be added. throw new WorkloadException( - $"Docker Installtion is not supported on the current platform {this.Platform} through VC." + + $"Docker Installation is not supported on the current platform {this.Platform} through VC." + $"Supported Platforms include:" + $" Unix ", ErrorReason.PlatformNotSupported); diff --git a/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.ps1 b/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.ps1 index a0a5a3b6f7..9d7d20c54c 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.ps1 +++ b/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.ps1 @@ -64,7 +64,7 @@ .PARAMETER DryRun If set it will not perform installation but instead display what command line to use to consistently install currently requested version of dotnet cli. In example if you specify version 'latest' it will display a link - with specific version so that this command can be used deterministicly in a build script. + with specific version so that this command can be used deterministically in a build script. It also displays binaries location if you prefer to install or download it yourself. .PARAMETER NoPath By default this script will set environment variable PATH for the current process to the binaries folder inside installation folder. @@ -96,7 +96,7 @@ Determines the SDK version from a user specified global.json file Note: global.json must have a value for 'SDK:Version' .PARAMETER DownloadTimeout - Determines timeout duration in seconds for dowloading of the SDK file + Determines timeout duration in seconds for downloading of the SDK file Default: 1200 seconds (20 minutes) .PARAMETER KeepZip If set, downloaded file is kept diff --git a/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.sh b/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.sh index bb7e9312ba..dfd5a412d2 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.sh +++ b/src/VirtualClient/VirtualClient.Dependencies/DotNet/dotnet-install.sh @@ -1446,7 +1446,7 @@ generate_regular_links() { link_types+=("legacy") else legacy_download_link="" - say_verbose "Cound not construct a legacy_download_link; omitting..." + say_verbose "Could not construct a legacy_download_link; omitting..." fi # Check if the SDK version is already installed. diff --git a/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerConfiguration.cs b/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerConfiguration.cs index f1dbaeeab9..e08d063455 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerConfiguration.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerConfiguration.cs @@ -42,7 +42,7 @@ public MySQLServerConfiguration(IServiceCollection dependencies, IDictionary - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public string Action { @@ -53,7 +53,7 @@ public string Action } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public bool SkipInitialize { diff --git a/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerInstallation.cs index fbdfe3a4ae..f0c94920f5 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/MySqlServer/MySqlServerInstallation.cs @@ -38,7 +38,7 @@ public MySQLServerInstallation(IServiceCollection dependencies, IDictionary - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public string Action { @@ -49,7 +49,7 @@ public string Action } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public bool SkipInitialize { diff --git a/src/VirtualClient/VirtualClient.Dependencies/NvidiaContainerToolkitInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/NvidiaContainerToolkitInstallation.cs index 17ea9e253f..c3bca7eacb 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/NvidiaContainerToolkitInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/NvidiaContainerToolkitInstallation.cs @@ -72,7 +72,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel break; default: - // different distro installation to be addded. + // different distro installation to be added. throw new WorkloadException( $"Nvidia Container Toolkit Installation is not supported by Virtual Client on the current Linux distro '{distroInfo.LinuxDistribution}'", ErrorReason.LinuxDistributionNotSupported); diff --git a/src/VirtualClient/VirtualClient.Dependencies/OpenFOAMInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/OpenFOAMInstallation.cs index 39e39fbd4d..29f5cef33c 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/OpenFOAMInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/OpenFOAMInstallation.cs @@ -83,7 +83,7 @@ await this.ExecuteCommandAsync(command, null, telemetryContext, cancellationToke else { throw new DependencyException( - $"Linux distrubution {linuxDistroInfo.LinuxDistribution.ToString()} is not supported with OpenFOAM.", + $"Linux distribution {linuxDistroInfo.LinuxDistribution.ToString()} is not supported with OpenFOAM.", ErrorReason.LinuxDistributionNotSupported); } } diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/AptPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/AptPackageInstallation.cs index 19983b5c56..47de89b307 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/AptPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/AptPackageInstallation.cs @@ -107,7 +107,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel List packages = this.Packages.Split(',', ';', StringSplitOptions.RemoveEmptyEntries).ToList(); ISystemManagement systemManagement = this.Dependencies.GetService(); - // Apt installtion only applies to Linux. + // Apt installation only applies to Linux. if (this.Platform != PlatformID.Unix || packages == null || !packages.Any()) { return; diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/ChocolateyPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/ChocolateyPackageInstallation.cs index 24b0b6514a..4496604a98 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/ChocolateyPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/ChocolateyPackageInstallation.cs @@ -88,7 +88,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel List packages = this.Packages.Split(',', ';', StringSplitOptions.RemoveEmptyEntries).ToList(); - // Choco installtion only applies to Windows. + // Choco installation only applies to Windows. if (this.Platform != PlatformID.Win32NT || packages == null || !packages.Any()) { return; @@ -132,7 +132,7 @@ await this.LogProcessDetailsAsync(process, telemetryContext, "Chocolatey") this.SetEnvironmentVariable(EnvironmentVariable.PATH, this.Combine(programFilesPath, package, "bin"), append: true); } - // choco list doesn't work well enough and is going thorugh a rename/deprecating + // choco list doesn't work well enough and is going through a rename/deprecating // https://docs.chocolatey.org/en-us/choco/commands/list // Need to add the list/verify function once chocolatey releases 2.0 this.Logger.LogTraceMessage($"VirtualClient installed choco package(s): '[{string.Join(' ', packages)}]'.", EventContext.Persisted()); diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/DnfPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/DnfPackageInstallation.cs index 1a01045b8f..6c8d87d31d 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/DnfPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/DnfPackageInstallation.cs @@ -101,7 +101,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel List packages = this.Packages.Split(',', ';', StringSplitOptions.RemoveEmptyEntries).ToList(); ISystemManagement systemManagement = this.Dependencies.GetService(); - // Dnf installtion only applies to Linux. + // Dnf installation only applies to Linux. if (this.Platform != PlatformID.Unix || packages == null || !packages.Any()) { return; diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/LinuxPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/LinuxPackageInstallation.cs index 6f1451dd56..db20077b5e 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/LinuxPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/LinuxPackageInstallation.cs @@ -215,12 +215,12 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel case LinuxDistribution.Flatcar: throw new DependencyException( - $"You are on Linux distrubution {this.linuxDistroInfo.LinuxDistribution.ToString()}, which does not have a package manager.", + $"You are on Linux distribution {this.linuxDistroInfo.LinuxDistribution.ToString()}, which does not have a package manager.", ErrorReason.LinuxDistributionNotSupported); default: throw new DependencyException( - $"You are on Linux distrubution {this.linuxDistroInfo.LinuxDistribution.ToString()}, which has not been onboarded to VirtualClient.", + $"You are on Linux distribution {this.linuxDistroInfo.LinuxDistribution.ToString()}, which has not been onboarded to VirtualClient.", ErrorReason.LinuxDistributionNotSupported); } diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/YumPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/YumPackageInstallation.cs index 15fa89012c..2e729fc1d9 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/YumPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/YumPackageInstallation.cs @@ -95,7 +95,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel List packages = this.Packages.Split(',', ';', StringSplitOptions.RemoveEmptyEntries).ToList(); ISystemManagement systemManagement = this.Dependencies.GetService(); - // Yum installtion only applies to Linux. + // Yum installation only applies to Linux. if (this.Platform != PlatformID.Unix || packages == null || !packages.Any()) { return; diff --git a/src/VirtualClient/VirtualClient.Dependencies/Packaging/ZypperPackageInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/Packaging/ZypperPackageInstallation.cs index a73f1e94f4..17eca204e8 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/Packaging/ZypperPackageInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/Packaging/ZypperPackageInstallation.cs @@ -95,7 +95,7 @@ protected override async Task ExecuteAsync(EventContext telemetryContext, Cancel List packages = this.Packages.Split(',', ';', StringSplitOptions.RemoveEmptyEntries).ToList(); ISystemManagement systemManagement = this.Dependencies.GetService(); - // Zypper installtion only applies to Linux. + // Zypper installation only applies to Linux. if (this.Platform != PlatformID.Unix || packages == null || !packages.Any()) { return; diff --git a/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerConfiguration.cs b/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerConfiguration.cs index ddb880b7e1..c274bb9c45 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerConfiguration.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerConfiguration.cs @@ -45,7 +45,7 @@ public PostgreSQLServerConfiguration(IServiceCollection dependencies, IDictionar } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public string Action { @@ -56,7 +56,7 @@ public string Action } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public bool SkipInitialize { diff --git a/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerInstallation.cs b/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerInstallation.cs index 2fe1b13b7d..7de5f25d75 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerInstallation.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerInstallation.cs @@ -36,7 +36,7 @@ public PostgreSQLServerInstallation(IServiceCollection dependencies, IDictionary } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public string Action { @@ -47,7 +47,7 @@ public string Action } /// - /// The specifed action that controls the execution of the dependency. + /// The specified action that controls the execution of the dependency. /// public bool SkipInitialize { diff --git a/src/VirtualClient/VirtualClient.Dependencies/SetEnvironmentVariable.cs b/src/VirtualClient/VirtualClient.Dependencies/SetEnvironmentVariable.cs index fd44c12f3d..ddbb27e28f 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/SetEnvironmentVariable.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/SetEnvironmentVariable.cs @@ -28,8 +28,8 @@ public SetEnvironmentVariable(IServiceCollection dependencies, IDictionary - /// Delimitered environment varaible - /// Example: Varaible1=A;Variable2=B + /// Delimitered environment variable + /// Example: Variable1=A;Variable2=B /// public string EnvironmentVariables { diff --git a/src/VirtualClient/VirtualClient.Main/OptionFactory.cs b/src/VirtualClient/VirtualClient.Main/OptionFactory.cs index 7ddc9999ef..15c7a4df0e 100644 --- a/src/VirtualClient/VirtualClient.Main/OptionFactory.cs +++ b/src/VirtualClient/VirtualClient.Main/OptionFactory.cs @@ -1596,7 +1596,7 @@ private static ProfileTiming ParseProfileIterations(ArgumentResult parsedResult) if (iterations <= 0) { throw new ArgumentException( - $"Invalid iteartion value '{iterations}' provided for the iterations option. " + + $"Invalid iteration value '{iterations}' provided for the iterations option. " + $"The iterations parameter must be greater than zero."); } diff --git a/src/VirtualClient/VirtualClient.Main/profiles/PERF-STRESSNG.json b/src/VirtualClient/VirtualClient.Main/profiles/PERF-STRESSNG.json index c9fe1c8923..252df0b8a5 100644 --- a/src/VirtualClient/VirtualClient.Main/profiles/PERF-STRESSNG.json +++ b/src/VirtualClient/VirtualClient.Main/profiles/PERF-STRESSNG.json @@ -5,7 +5,7 @@ "RecommendedMinimumExecutionTime": "00:05:00", "SupportedPlatforms": "linux-x64,linux-arm64", "SupportedOperatingSystems": "CBL-Mariner,CentOS,Debian,RedHat,Suse,Ubuntu", - "SpecialInstrucions": "The commandline parameter --yaml is programatically added, do not add it in profile. By default, --metrics flag is ON, --cpu is set to ProcessorCount and the default timeout is 60 seconds." + "SpecialInstrucions": "The commandline parameter --yaml is programmatically added, do not add it in profile. By default, --metrics flag is ON, --cpu is set to ProcessorCount and the default timeout is 60 seconds." }, "Parameters": { "CommandLine": "--timeout 60" diff --git a/src/VirtualClient/VirtualClient.Monitors.UnitTests/Nvidia-Smi/NvidiaSmiResultsParserUnitTests.cs b/src/VirtualClient/VirtualClient.Monitors.UnitTests/Nvidia-Smi/NvidiaSmiResultsParserUnitTests.cs index 3c960a41ce..fa3d288225 100644 --- a/src/VirtualClient/VirtualClient.Monitors.UnitTests/Nvidia-Smi/NvidiaSmiResultsParserUnitTests.cs +++ b/src/VirtualClient/VirtualClient.Monitors.UnitTests/Nvidia-Smi/NvidiaSmiResultsParserUnitTests.cs @@ -85,8 +85,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario1xT4() MetricAssert.Exists(metrics, "gpu0_%_utilization", 1); MetricAssert.Exists(metrics, "gpu0_%_memory_utilization", 2); - MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celcius"); - MetricAssert.Exists(metrics, "gpu0_memory_temperature", 35, "celcius"); + MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celsius"); + MetricAssert.Exists(metrics, "gpu0_memory_temperature", 35, "celsius"); MetricAssert.Exists(metrics, "gpu0_power_draw_average", 70.89, "watts"); MetricAssert.Exists(metrics, "gpu0_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu0_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -129,7 +129,7 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario1xT4_2( MetricAssert.Exists(metrics, "gpu0_%_utilization", 2); MetricAssert.Exists(metrics, "gpu0_%_memory_utilization", 3); - MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celcius"); + MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celsius"); MetricAssert.Exists(metrics, "gpu0_graphics_clock_speed", 300, "megahertz"); MetricAssert.Exists(metrics, "gpu0_streaming_multiprocessor_clock_speed", 300, "megahertz"); MetricAssert.Exists(metrics, "gpu0_video_clock_speed", 540, "megahertz"); @@ -171,8 +171,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() Assert.AreEqual(248, metrics.Count); MetricAssert.Exists(metrics, "gpu0_%_utilization", 0); MetricAssert.Exists(metrics, "gpu0_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celcius"); - MetricAssert.Exists(metrics, "gpu0_memory_temperature", 35, "celcius"); + MetricAssert.Exists(metrics, "gpu0_temperature", 26, "celsius"); + MetricAssert.Exists(metrics, "gpu0_memory_temperature", 35, "celsius"); MetricAssert.Exists(metrics, "gpu0_power_draw_average", 70.89, "watts"); MetricAssert.Exists(metrics, "gpu0_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu0_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -203,8 +203,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu1_%_utilization", 0); MetricAssert.Exists(metrics, "gpu1_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu1_temperature", 26, "celcius"); - MetricAssert.Exists(metrics, "gpu1_memory_temperature", 34, "celcius"); + MetricAssert.Exists(metrics, "gpu1_temperature", 26, "celsius"); + MetricAssert.Exists(metrics, "gpu1_memory_temperature", 34, "celsius"); MetricAssert.Exists(metrics, "gpu1_power_draw_average", 71.71, "watts"); MetricAssert.Exists(metrics, "gpu1_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu1_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -235,8 +235,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu2_%_utilization", 0); MetricAssert.Exists(metrics, "gpu2_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu2_temperature", 25, "celcius"); - MetricAssert.Exists(metrics, "gpu2_memory_temperature", 33, "celcius"); + MetricAssert.Exists(metrics, "gpu2_temperature", 25, "celsius"); + MetricAssert.Exists(metrics, "gpu2_memory_temperature", 33, "celsius"); MetricAssert.Exists(metrics, "gpu2_power_draw_average", 70.78, "watts"); MetricAssert.Exists(metrics, "gpu2_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu2_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -267,8 +267,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu3_%_utilization", 0); MetricAssert.Exists(metrics, "gpu3_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu3_temperature", 25, "celcius"); - MetricAssert.Exists(metrics, "gpu3_memory_temperature", 33, "celcius"); + MetricAssert.Exists(metrics, "gpu3_temperature", 25, "celsius"); + MetricAssert.Exists(metrics, "gpu3_memory_temperature", 33, "celsius"); MetricAssert.Exists(metrics, "gpu3_power_draw_average", 72.17, "watts"); MetricAssert.Exists(metrics, "gpu3_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu3_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -299,8 +299,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu4_%_utilization", 0); MetricAssert.Exists(metrics, "gpu4_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu4_temperature", 26, "celcius"); - MetricAssert.Exists(metrics, "gpu4_memory_temperature", 35, "celcius"); + MetricAssert.Exists(metrics, "gpu4_temperature", 26, "celsius"); + MetricAssert.Exists(metrics, "gpu4_memory_temperature", 35, "celsius"); MetricAssert.Exists(metrics, "gpu4_power_draw_average", 70.89, "watts"); MetricAssert.Exists(metrics, "gpu4_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu4_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -331,8 +331,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu5_%_utilization", 0); MetricAssert.Exists(metrics, "gpu5_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu5_temperature", 26, "celcius"); - MetricAssert.Exists(metrics, "gpu5_memory_temperature", 34, "celcius"); + MetricAssert.Exists(metrics, "gpu5_temperature", 26, "celsius"); + MetricAssert.Exists(metrics, "gpu5_memory_temperature", 34, "celsius"); MetricAssert.Exists(metrics, "gpu5_power_draw_average", 71.71, "watts"); MetricAssert.Exists(metrics, "gpu5_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu5_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -363,8 +363,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu6_%_utilization", 0); MetricAssert.Exists(metrics, "gpu6_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu6_temperature", 25, "celcius"); - MetricAssert.Exists(metrics, "gpu6_memory_temperature", 33, "celcius"); + MetricAssert.Exists(metrics, "gpu6_temperature", 25, "celsius"); + MetricAssert.Exists(metrics, "gpu6_memory_temperature", 33, "celsius"); MetricAssert.Exists(metrics, "gpu6_power_draw_average", 70.78, "watts"); MetricAssert.Exists(metrics, "gpu6_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu6_streaming_multiprocessor_clock_speed", 345, "megahertz"); @@ -395,8 +395,8 @@ public void NvidiaSmiParserParsesExpectedMetricsFromQueryResults_Scenario4xT4() MetricAssert.Exists(metrics, "gpu7_%_utilization", 0); MetricAssert.Exists(metrics, "gpu7_%_memory_utilization", 0); - MetricAssert.Exists(metrics, "gpu7_temperature", 25, "celcius"); - MetricAssert.Exists(metrics, "gpu7_memory_temperature", 33, "celcius"); + MetricAssert.Exists(metrics, "gpu7_temperature", 25, "celsius"); + MetricAssert.Exists(metrics, "gpu7_memory_temperature", 33, "celsius"); MetricAssert.Exists(metrics, "gpu7_power_draw_average", 72.17, "watts"); MetricAssert.Exists(metrics, "gpu7_graphics_clock_speed", 345, "megahertz"); MetricAssert.Exists(metrics, "gpu7_streaming_multiprocessor_clock_speed", 345, "megahertz"); diff --git a/src/VirtualClient/VirtualClient.Monitors/Lspci/PciDevice.cs b/src/VirtualClient/VirtualClient.Monitors/Lspci/PciDevice.cs index a3684492a4..09e2df699f 100644 --- a/src/VirtualClient/VirtualClient.Monitors/Lspci/PciDevice.cs +++ b/src/VirtualClient/VirtualClient.Monitors/Lspci/PciDevice.cs @@ -31,7 +31,7 @@ public class PciDevice public List Capabilities { get; set; } = new List { }; /// - /// Data contract for capabiilities in lspci output. + /// Data contract for capabilities in lspci output. /// -------------------------------Example--------------------------------- /// Capabilities: [80] MSI-X: Enable- Count=1 Masked- /// Vector table: BAR=0 offset=00002000 diff --git a/src/VirtualClient/VirtualClient.Monitors/Nvidia-Smi/NvidiaSmiResultsParser.cs b/src/VirtualClient/VirtualClient.Monitors/Nvidia-Smi/NvidiaSmiResultsParser.cs index e0f4525c92..d76896715e 100644 --- a/src/VirtualClient/VirtualClient.Monitors/Nvidia-Smi/NvidiaSmiResultsParser.cs +++ b/src/VirtualClient/VirtualClient.Monitors/Nvidia-Smi/NvidiaSmiResultsParser.cs @@ -22,8 +22,8 @@ public static class NvidiaSmiResultsParser { { "%_utilization", ("utilization.gpu [%]", null, "The current percentage utilization of the GPU.", MetricRelativity.Undefined) }, { "%_memory_utilization", ("utilization.memory [%]", null, "The current percentage of memory utilization for the GPU.", MetricRelativity.Undefined) }, - { "temperature", ("temperature.gpu", MetricUnit.Celcius, "The current temperature reading (in celcius) for the GPU.", MetricRelativity.LowerIsBetter) }, - { "memory_temperature", ("temperature.memory", MetricUnit.Celcius, "The current temperature reading (in celcius) for the GPU memory components.", MetricRelativity.LowerIsBetter) }, + { "temperature", ("temperature.gpu", MetricUnit.Celsius, "The current temperature reading (in celsius) for the GPU.", MetricRelativity.LowerIsBetter) }, + { "memory_temperature", ("temperature.memory", MetricUnit.Celsius, "The current temperature reading (in celsius) for the GPU memory components.", MetricRelativity.LowerIsBetter) }, { "power_draw_average", ("power.draw.average [W]", MetricUnit.Watts, "The current power draw (in watts) for the GPU", MetricRelativity.LowerIsBetter) }, { "graphics_clock_speed", ("clocks.current.graphics [MHz]", MetricUnit.Megahertz, "The current clock speed for GPU graphics instruction processing.", MetricRelativity.Undefined) }, { "streaming_multiprocessor_clock_speed", ("clocks.current.sm [MHz]", MetricUnit.Megahertz, "The current clock speed for GPU streaming multiprocessor instruction processing.", MetricRelativity.Undefined) }, diff --git a/src/VirtualClient/VirtualClient.Monitors/PerformanceCounters/WindowsPerformanceCounterMonitor.cs b/src/VirtualClient/VirtualClient.Monitors/PerformanceCounters/WindowsPerformanceCounterMonitor.cs index b90981375e..b1848ea331 100644 --- a/src/VirtualClient/VirtualClient.Monitors/PerformanceCounters/WindowsPerformanceCounterMonitor.cs +++ b/src/VirtualClient/VirtualClient.Monitors/PerformanceCounters/WindowsPerformanceCounterMonitor.cs @@ -361,7 +361,7 @@ protected Task SnapshotCountersAsync(EventContext telemetryContext, Cancellation { // This type of exception will happen if the cancellation token is cancelled // in the Task.Delay() call above. We don't want to surface this as an exception - // becuase it is entirely expected. + // because it is entirely expected. } catch (Exception exc) { diff --git a/src/VirtualClient/VirtualClient.TestExtensions/DataTableTestExtensions.cs b/src/VirtualClient/VirtualClient.TestExtensions/DataTableTestExtensions.cs index a0e62a280c..5a6994fe53 100644 --- a/src/VirtualClient/VirtualClient.TestExtensions/DataTableTestExtensions.cs +++ b/src/VirtualClient/VirtualClient.TestExtensions/DataTableTestExtensions.cs @@ -67,7 +67,7 @@ public static void PrintDataTable(this DataTable dataTable) } /// - /// Data table with formated column width. + /// Data table with formatted column width. /// /// Input data table. public static void PrintDataTableFormatted(this DataTable dataTable) diff --git a/src/VirtualClient/VirtualClient.UnitTests/OptionFactoryTests.cs b/src/VirtualClient/VirtualClient.UnitTests/OptionFactoryTests.cs index 921e78c680..5b25972601 100644 --- a/src/VirtualClient/VirtualClient.UnitTests/OptionFactoryTests.cs +++ b/src/VirtualClient/VirtualClient.UnitTests/OptionFactoryTests.cs @@ -265,7 +265,7 @@ public void LoggerOptionSupportsMultipleLoggerInputs(string input) [Test] [TestCaseSource(nameof(GetExampleStorageAccountConnectionStrings))] - public void ContentStoreOptionSupportsValidStoageAccountConnectionStrings(string connectionToken) + public void ContentStoreOptionSupportsValidStorageAccountConnectionStrings(string connectionToken) { Option option = OptionFactory.CreateContentStoreOption(); ParseResult result = option.Parse($"--content-store={connectionToken}"); @@ -932,7 +932,7 @@ public void PackageStoreOptionSupportsExpectedAliases(string alias) [Test] [TestCaseSource(nameof(GetExampleStorageAccountConnectionStrings))] - public void PackageStoreOptionSupportsValidStoageAccountConnectionStrings(string connectionToken) + public void PackageStoreOptionSupportsValidStorageAccountConnectionStrings(string connectionToken) { Option option = OptionFactory.CreatePackageStoreOption(); ParseResult result = option.Parse($"--package-store={connectionToken}"); diff --git a/website/docs/dependencies/0010-install-linux-packages.md b/website/docs/dependencies/0010-install-linux-packages.md index bdc42f230d..cc91ee03cc 100644 --- a/website/docs/dependencies/0010-install-linux-packages.md +++ b/website/docs/dependencies/0010-install-linux-packages.md @@ -44,7 +44,7 @@ different Linux distros are as follows: - Packages with the same name across all distros. - Packages with specific names depending upon the distro. -- Packages with specific names dependending upon the package manager. +- Packages with specific names depending upon the package manager. ## Example: Packages that have the same name across distros This is the simplest case. The package is well-known and all package managers use the same name for the package. diff --git a/website/docs/dependencies/0011-install-snap-packages.md b/website/docs/dependencies/0011-install-snap-packages.md index e8c74f0f5e..9adbfed4cd 100644 --- a/website/docs/dependencies/0011-install-snap-packages.md +++ b/website/docs/dependencies/0011-install-snap-packages.md @@ -23,7 +23,7 @@ The following section describes the parameters used by the individual component ## Examples In this example, VC installs the snapd service and a few packages using both the SnapPackageInstallation and LinuxPackageInstallation dependencies. -For SUSE distributions, confirm that the version in the zypper repository link matches the specific distribution that is being used on the VM (ie. Leap 15.4 vs. Leap 15.2 vs. Tumbleweed). More info on installing snapd on SUSE can be found [in the offical snap documentation](https://snapcraft.io/docs/installing-snap-on-opensuse). +For SUSE distributions, confirm that the version in the zypper repository link matches the specific distribution that is being used on the VM (ie. Leap 15.4 vs. Leap 15.2 vs. Tumbleweed). More info on installing snapd on SUSE can be found [in the official snap documentation](https://snapcraft.io/docs/installing-snap-on-opensuse). For CentOS7 distributions, the epel-release repository must be installed before the snapd service. More info on that can be found [here](https://snapcraft.io/install/snapd/centos). For RHEL7 distributions, the latest repository name can be found [here](https://snapcraft.io/install/snapd/rhel). diff --git a/website/docs/dependencies/0035-set-envrionment-variables.md b/website/docs/dependencies/0035-set-envrionment-variables.md index dc67381e08..f81ac8caf5 100644 --- a/website/docs/dependencies/0035-set-envrionment-variables.md +++ b/website/docs/dependencies/0035-set-envrionment-variables.md @@ -12,7 +12,7 @@ The following section describes the parameters used by the individual component | **Parameter** | **Required** | **Description** | |---------------|--------------|---------------------------------------------------------| -| EnvironmentVariables | No | Semicolon delimtered key value pairs with equal sign. Example: "Varaible1=A;Variable2=B" | +| EnvironmentVariables | No | Semicolon delimtered key value pairs with equal sign. Example: "Variable1=A;Variable2=B" | ## Example The following section describes the parameters used by the individual component in the profile. @@ -23,7 +23,7 @@ The following section describes the parameters used by the individual component "Type": "SetEnvironmentVariable", "Parameters": { "Scenario": "SetEnvironmentVariable", - "EnvironmentVariables": "Varaible1=A;Variable2=B", + "EnvironmentVariables": "Variable1=A;Variable2=B", } } ``` \ No newline at end of file diff --git a/website/docs/dependencies/0080-install-amd-drivers.md b/website/docs/dependencies/0080-install-amd-drivers.md index 4242d32520..722a49766d 100644 --- a/website/docs/dependencies/0080-install-amd-drivers.md +++ b/website/docs/dependencies/0080-install-amd-drivers.md @@ -43,4 +43,4 @@ The following section describes the parameters used by the individual component Note: Virtual Client is only tested with MI200x systems using installation file - https://repo.radeon.com/amdgpu-install/5.5/ubuntu/focal/amdgpu-install_5.5.50500-1_all.deb. ## Supported Linux Distros -* Ubunutu +* Ubuntu diff --git a/website/docs/developing/0010-develop-guide.md b/website/docs/developing/0010-develop-guide.md index 7dd53629ca..ca9816f914 100644 --- a/website/docs/developing/0010-develop-guide.md +++ b/website/docs/developing/0010-develop-guide.md @@ -90,7 +90,7 @@ important thing is to keep things as simple as possible. distinct workload executors, monitors and dependencies exist in Virtual Client with the list constantly growing. * **Functionality that is shared by all components should be part of the 'Core' project** - There are dependencies that are required by most components in the Virtual Client. The implmentations of these hold a high quality bar + There are dependencies that are required by most components in the Virtual Client. The implementations of these hold a high quality bar because they are so fundamental to the operations of the Virtual Client application as a whole. Most of the necessary dependencies have been implemented. However if a new dependency is required in Virtual Client that is to be shared across all providers, it should be implemented in the 'Core' project. Note that something is not "common" because it might be in the future. A component is common when it is used by many @@ -236,7 +236,7 @@ exist within the Virtual Client platform/core codebase. It is helpful to underst This project contains "Fundamental" workload/test executor implementations. The components within this project can be seen referenced in the 'Actions' section of related workload profiles. - This project also contains classes/implementations of various results/raw text parsers that are used in conjuction with workload/test executors + This project also contains classes/implementations of various results/raw text parsers that are used in conjunction with workload/test executors to read important information/data (e.g. metrics) from the output of workloads. The parsing of results is complex enough to keep the implementation separate from the workload executors and to ensure reusability for different implementations of a related workload executor. @@ -254,7 +254,7 @@ exist within the Virtual Client platform/core codebase. It is helpful to underst This project contains "Fundamental" background monitor implementations. The components within this project can be seen referenced in the 'Monitors' section of related monitoring profiles. - This project also contains classes/implementations of various results/raw text parsers that are used in conjuction with monitors + This project also contains classes/implementations of various results/raw text parsers that are used in conjunction with monitors to read important information/data (e.g. metrics) from the output of monitors. The parsing of results is complex enough to keep the implementation separate from the monitors and to ensure reusability for different implementations of a related monitor. @@ -397,7 +397,7 @@ exhaustive list but does illustrate things that are "fundamental" to development The C# programming language (as of version 6.0) has great support for asynchronous programming. Asynchronous programming allows for the application to be far more efficient in the usage of system primitive resources for I/O-bound or CPU-bound operations. The Virtual Client runtime platform itself MUST run as efficiently as possible. This is especially the case when it is running a resource-sensitive benchmark, workload or test. This is because the resources that the - Virtual Client itself uses in order to operate as a runtime platform on the system affect the resources available t othe workload and can cause "noise" in the + Virtual Client itself uses in order to operate as a runtime platform on the system affect the resources available t other workload and can cause "noise" in the data that is emitted. For example, were the Virtual Client itself to use too many CPU/process resources/cycles when running a workload that is designed to benchmark the performance of the CPU/processor, the performance results of the benchmark could be skewed to be less accurate. @@ -517,7 +517,7 @@ exhaustive list but does illustrate things that are "fundamental" to development ``` csharp // For example: - // It is usefult to capture context-specific information related to a process being executed + // It is useful to capture context-specific information related to a process being executed // (the command, arguments, exit codes, standard output, standard error etc...) EventContext relatedContext = telemetryContext.Clone() .AddContext("command", workload.Command) @@ -592,7 +592,7 @@ The following methods are executed in the order specified for each and every com method is required to be implemented. The other methods are optional and may be overridden in the new component to meet the needs of the developer implementation. * **IsSupported** - Method is executed to determin whether or not the component should be executed on the system. Reasons why a component might not be valid/supported + Method is executed to determine whether or not the component should be executed on the system. Reasons why a component might not be valid/supported for a given system include: * The component or its dependencies cannot run on the current platform/architecture (e.g. win-arm64, linux-arm64). * The component or its dependencies cannot run on the current distro of the operating system (e.g. Ubuntu, Redhat). @@ -675,13 +675,13 @@ logging is routed correctly. There are 3 different categories of telemetry in th // 1) A "Start" event is written capturing a timestamp at the beginning of the logic block operations // (e.g. AnyComponent.PerformOperationStart). // - // 2) A "Stop" event is written capturing a timestamp at the end of the logic block operations (e.g. AnyComponent.PerformOpertionStop). - // This event will contain a propery 'durationMs' in the telemetry message context/custom dimensions that defines the length of + // 2) A "Stop" event is written capturing a timestamp at the end of the logic block operations (e.g. AnyComponent.PerformOperationStop). + // This event will contain a property 'durationMs' in the telemetry message context/custom dimensions that defines the length of // time in milliseconds the logic took. This can be helpful when analyzing the performance of logic later on // without needing to perform date/time math. // // 3) Any exceptions/errors that are throw will be automatically captured and the error messages + callstack will be added to - // an "Error" message (e.g. AnyComponent.PerformOpertionError). + // an "Error" message (e.g. AnyComponent.PerformOperationError). // // All of this functionality is wrapped up in the extension method which allows for consistency in telemetry event names and // error handling while significantly reducing "noise" in the code related to telemetry logic. diff --git a/website/docs/developing/0021-develop-script-extensions.md b/website/docs/developing/0021-develop-script-extensions.md index 5979f3452a..6350723b14 100644 --- a/website/docs/developing/0021-develop-script-extensions.md +++ b/website/docs/developing/0021-develop-script-extensions.md @@ -257,7 +257,7 @@ script-based extensions development process. The following illustrates an exampl * **Include Documentation in the Package** Each hardware program comes with special considerations. Documentation related to the specific program should be included in either the root - directory for the package (e.g. README.md) or in a `docs` subdirectory within the package. Any non-automated setup requirments should be clearly + directory for the package (e.g. README.md) or in a `docs` subdirectory within the package. Any non-automated setup requirements should be clearly documented. ``` bash diff --git a/website/docs/developing/0030-workload-onboarding.md b/website/docs/developing/0030-workload-onboarding.md index 9f66c3090b..c5af3d33d7 100644 --- a/website/docs/developing/0030-workload-onboarding.md +++ b/website/docs/developing/0030-workload-onboarding.md @@ -39,7 +39,7 @@ to packaging workloads and dependencies in easy-to-consume Virtual Client packag ``` ## Step 4: Update Package Manager and Unit Tests -* Update PackageManager.cs of project VirtualClient.Core to incluide the details of all the packages required to be downloaded. +* Update PackageManager.cs of project VirtualClient.Core to include the details of all the packages required to be downloaded. * Update PackageManagerTests.cs of project VirtualClient.Core.UnitTests to include the unit tests of the changes. ## Step 5: Profile Creation @@ -62,7 +62,7 @@ to packaging workloads and dependencies in easy-to-consume Virtual Client packag ## Step 7: Dependencies Creation * In case, Workload requires one time set-up on VM then that can be added as a dependency in the VC. -* Add \.cs(IISInstallation.cs) file in VirtualClient.Dependencies project. +* Add \.cs(IISInstallation.cs) file in VirtualClient.Dependencies project. * Add its unit tests in project VirtualClient.Dependencies.UnitTests project. * This dependency can be added in profile file created for workload in VirtualClient.Main. diff --git a/website/docs/developing/0060-workload-recommendations.md b/website/docs/developing/0060-workload-recommendations.md index dcdaf60bdd..cbf406be30 100644 --- a/website/docs/developing/0060-workload-recommendations.md +++ b/website/docs/developing/0060-workload-recommendations.md @@ -28,7 +28,7 @@ The following sections describes some of the aspects of good options for workloa * #### Is Easy to Integrate with Other Systems Good workloads are generally easy to use thus making it easy to integrate into the larger execution system. This reduces the overhead required for - teams to onboard new and valueable test scenarios. + teams to onboard new and valuable test scenarios. ## Additional Considerations The following section offers a few other recommendations when selecting a workload for easy integrated into the Virtual Client. diff --git a/website/docs/developing/0061-build-docker-container.md b/website/docs/developing/0061-build-docker-container.md index 97be90fa27..a6ba3fe487 100644 --- a/website/docs/developing/0061-build-docker-container.md +++ b/website/docs/developing/0061-build-docker-container.md @@ -2,7 +2,7 @@ The following sections cover how to build a Docker image that will contain the Virtual Client. ## Installing Docker on your Windows Dev machine -To run Docker on your presumeably Windows Dev Machine, you need to install both Docker and WSL. Reboots might be required. +To run Docker on your presumably Windows Dev Machine, you need to install both Docker and WSL. Reboots might be required. 1. [Docker desktop for Windows](https://hub.docker.com/editions/community/docker-ce-desktop-windows) 2. [Install Windows Subsystem for Linux](https://docs.microsoft.com/en-us/windows/wsl/install-win10#manual-installation-steps) diff --git a/website/docs/developing/0070-error-handling.md b/website/docs/developing/0070-error-handling.md index b7e20ebbaf..4e35115012 100644 --- a/website/docs/developing/0070-error-handling.md +++ b/website/docs/developing/0070-error-handling.md @@ -17,7 +17,7 @@ of exceptions that are raised/thrown based on the data type of the exception as ``` csharp // Custom exception classes in the Virtual Client platform/core derive from the base VirtualClientException class. Each of the -// platform/core exception classes implement the same constructors for consisteny. The 'ErrorReason' provided is an important distinction. +// platform/core exception classes implement the same constructors for consistency. The 'ErrorReason' provided is an important distinction. public class WorkloadException : VirtualClientException { public WorkloadException() diff --git a/website/docs/developing/0090-testing.md b/website/docs/developing/0090-testing.md index 05e555cfcf..c9897fdb46 100644 --- a/website/docs/developing/0090-testing.md +++ b/website/docs/developing/0090-testing.md @@ -47,7 +47,7 @@ in a single place or to use C# extension methods to do the same. closely mimics certain "real-life" environment/system behavior. ## Test Setup Mechanics -Each of the tests in the Virtual Client codebase (unit as well as functional) uses one or more of the testing fixtures noted above. This simplifes the process of testing code +Each of the tests in the Virtual Client codebase (unit as well as functional) uses one or more of the testing fixtures noted above. This simplifies the process of testing code by instilling repeatable patterns and reducing redundancy/duplication in setup requirements. The ultimate goals are as follows: * Remove code from individual tests and test methods that is used purely to setup mock/fake behaviors. diff --git a/website/docs/guides/0011-profiles.md b/website/docs/guides/0011-profiles.md index 2aaa0b7e7c..e8d069bf92 100644 --- a/website/docs/guides/0011-profiles.md +++ b/website/docs/guides/0011-profiles.md @@ -4,7 +4,7 @@ of as recipes for how to utilize resources and to work the system. Profiles are Actions, Monitors and Dependencies. Although a profile may contain any number of these sections, none of the sections are absolutely required. This allows users flexibility when creating profiles for -reusability. For example, it is common for the Virtual Client team to have profiles specific to running workloads on the system separat from profiles specific to running +reusability. For example, it is common for the Virtual Client team to have profiles specific to running workloads on the system separate from profiles specific to running monitors on the system. This allows a user to run a set of monitors with any number of different sets of workloads. In the examples below, the profiles that start with the term 'PERF' are ones that are designed to run workloads on the system. Profiles that start with the term 'MONITORS' are designed to run different sets of monitors on the system in the background while the workloads are running. @@ -32,7 +32,7 @@ properties that one might find in a profile. The section 'Parameters' within the profile defines a set of 1 or more parameters (typically with default values) that can be used to override the default values in the components that are part of the 'Actions', 'Monitors' or 'Dependencies' sections. In general, Virtual Client profiles are not meant to be overly general purpose. They represent tested and vetted recipes for how to utilize resources and work a given system. Whereas any number of parameters can be defined in the 'Parameters' section, it is common practice to allow overrides to a minimum -set. This helps to ensure the purpose and consistency of the profile operations on the system cannnot diverge too far from the original intentions. +set. This helps to ensure the purpose and consistency of the profile operations on the system cannot diverge too far from the original intentions. ``` "Parameters": { diff --git a/website/docs/guides/0012-custom-execution-order.md b/website/docs/guides/0012-custom-execution-order.md index 2f9a24a72c..e82a09dca2 100644 --- a/website/docs/guides/0012-custom-execution-order.md +++ b/website/docs/guides/0012-custom-execution-order.md @@ -86,7 +86,7 @@ Executes all child components **in parallel**, and **repeats** this execution fo | MinimumIterations | Minimum number of times each child component should run | >= 0 | 0 | ### Example -Here, the child components will start execution parallely, and each component will run at least three times due to the `MinimumIterations` parameter. They will complete after 10 minutes if each component has completed the run three times, or else it will wait for three runs of each component. Thus, the MinimumIterations parameter supersedes the Duration parameter if the latter is not met. +Here, the child components will start execution parallelly, and each component will run at least three times due to the `MinimumIterations` parameter. They will complete after 10 minutes if each component has completed the run three times, or else it will wait for three runs of each component. Thus, the MinimumIterations parameter supersedes the Duration parameter if the latter is not met. Note that By default, the MinimumIterations parameter is set to 0, meaning that the components will run until the Duration is met. If you want to ensure that each component runs at least once, you can set MinimumIterations to 1 or more. diff --git a/website/docs/guides/0020-client-server.md b/website/docs/guides/0020-client-server.md index 4645ead8bb..0c637c68a3 100644 --- a/website/docs/guides/0020-client-server.md +++ b/website/docs/guides/0020-client-server.md @@ -120,7 +120,7 @@ the system must be modified to allow for it. This means that any client/server w On Windows systems, the workload should be ran under an account with access to modify the firewall settings or with 'Administrative' privileges. Similarly, on Linux systems, the workload should be ran under an account with access to modify the firewall settings or with `sudo`. -The port in wich the REST API uses can be changed if needed. For example, it is possible that some other application running on the system is already using the default +The port in which the REST API uses can be changed if needed. For example, it is possible that some other application running on the system is already using the default port. The following examples illustrate how to use a different port: * [Command Line Options](./0010-command-line.md) diff --git a/website/docs/guides/0021-controller-agent.md b/website/docs/guides/0021-controller-agent.md index 2036d61b53..7396dc2c84 100644 --- a/website/docs/guides/0021-controller-agent.md +++ b/website/docs/guides/0021-controller-agent.md @@ -23,7 +23,7 @@ test controller systems. the following are required in order to use the Virtual Client as a test controller. * The test controller system MUST have internet access in order to support download of dependencies. -* Target systems MUST be network-accessible from the test controller system (e.g. same LAN). It is also recommeded that the target systems have some amount of direct internet connectivity in order to make system setup/configuration easier. See the ```Considerations``` section above. +* Target systems MUST be network-accessible from the test controller system (e.g. same LAN). It is also recommended that the target systems have some amount of direct internet connectivity in order to make system setup/configuration easier. See the ```Considerations``` section above. * SSH support MUST be installed/enabled on each target system. The support is native to Linux but requires a feature to be installed on Windows. [Get started with OpenSSH for Windows](https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse?tabs=gui&pivots=windows-server-2025) diff --git a/website/docs/guides/0220-usage-testing-disks.md b/website/docs/guides/0220-usage-testing-disks.md index 3d945a8eca..a38caf3ef4 100644 --- a/website/docs/guides/0220-usage-testing-disks.md +++ b/website/docs/guides/0220-usage-testing-disks.md @@ -1,5 +1,5 @@ # Usage: Testing Disks -VC automates disk formating and run storage workloads on the target systems. We documented the rules and the mechanism we used to identify disks to run workloads on. +VC automates disk formatting and run storage workloads on the target systems. We documented the rules and the mechanism we used to identify disks to run workloads on. ## Disk Mount Points On certain systems, Virtual Client may need to create mount points on each of the disks in order to have both permissions and a path to diff --git a/website/docs/guides/0600-integration-blob-storage.md b/website/docs/guides/0600-integration-blob-storage.md index bfd18a544e..912c6508af 100644 --- a/website/docs/guides/0600-integration-blob-storage.md +++ b/website/docs/guides/0600-integration-blob-storage.md @@ -16,7 +16,7 @@ The following stores are supported by the Virtual Client. The stores must be Azu # The blob container does not require authentication (i.e. blob-anonymous read access) VirtualClient.exe --profile=PERF-NETWORK.json --timeout=1440 --packageStore="https://any.blob.core.windows.net" - # The blob continer requires authentication (e.g. a SAS token) + # The blob container requires authentication (e.g. a SAS token) VirtualClient.exe --profile=PERF-NETWORK.json --timeout=1440 --packageStore="https://any.blob.core.windows.net/packages?sp=r&st=2022-05-09T18:31:45Z&se=2030-05-10T02:31:45Z&spr=https&sv=2020-08-04&sr=c&sig=..." ``` @@ -31,7 +31,7 @@ The following stores are supported by the Virtual Client. The stores must be Azu # The blob container does not require authentication (i.e. blob-anonymous read access) VirtualClient.exe --profile=PERF-NETWORK.json --timeout=1440 --contentStore="https://any.blob.core.windows.net" - # The blob continer requires authentication (e.g. a SAS token) + # The blob container requires authentication (e.g. a SAS token) VirtualClient.exe --profile=PERF-NETWORK.json --timeout=1440 --contentStore="https://any.blob.core.windows.net/packages?sp=r&st=2022-05-09T18:31:45Z&se=2030-05-10T02:31:45Z&spr=https&sv=2020-08-04&sr=c&sig=..." ``` diff --git a/website/docs/monitors/0300-nvidia-smi.md b/website/docs/monitors/0300-nvidia-smi.md index 66b9a0e4d0..04a41864f8 100644 --- a/website/docs/monitors/0300-nvidia-smi.md +++ b/website/docs/monitors/0300-nvidia-smi.md @@ -26,7 +26,7 @@ The following section describes the various counters/metrics that are available |-------------|-------------| | utilization.gpu | GPU Utilization percentage. | | utilization.memory | GPU Memory Utilization percentage. | -| temperature.gpu | GPU temperature in celsuis. | +| temperature.gpu | GPU temperature in celsius. | | temperature.memory | GPU memory temperature in celsuis. | | power.draw.average | Average GPU Power Draw in Watts. | | clocks.gr | GPU Graphics Clock in MHz. | diff --git a/website/docs/overview/0030-roadmap.md b/website/docs/overview/0030-roadmap.md index f64b41121d..a22b44326d 100644 --- a/website/docs/overview/0030-roadmap.md +++ b/website/docs/overview/0030-roadmap.md @@ -18,7 +18,7 @@ workload onboardings etc... - SPECjbb - SPECpower - Geekbench5 - - Other MSFT proprietory workloads that we are reviewing + - Other MSFT proprietary workloads that we are reviewing - Workloads in development - MySQL - OMbench @@ -38,7 +38,7 @@ workload onboardings etc... - Add documentation for the dependencies already supported. - Nvidia GPU driver and CUDA installation - Compiler Installation - - Docker insallation + - Docker installation - etc. - Onboard new dependencies diff --git a/website/docs/workloads/3dmark/3dmark-profiles.md b/website/docs/workloads/3dmark/3dmark-profiles.md index d16c831235..f4f48b6e09 100644 --- a/website/docs/workloads/3dmark/3dmark-profiles.md +++ b/website/docs/workloads/3dmark/3dmark-profiles.md @@ -12,7 +12,7 @@ Runs the stock 3DMark TimeSpy Workloads. * win-x64 * **Supports Disconnected Scenarios** - * Yes. Internet connection only required for lisence key validation. + * Yes. Internet connection only required for licence key validation. * **Dependencies** An NVIDIA or AMD GPU driver installation is required for this workload. @@ -25,7 +25,7 @@ Runs the stock 3DMark TimeSpy Workloads. | Parameter | Purpose | Default Value | |---------------------------|-------------------------------------------------------------------|---------------| - | LisenceKey | Required. The [3DMark](https://benchmarks.ul.com/3dmark?_ga=2.106445760.293481338.1681124251-1769566625.1681124251#windows) lisence key| None| + | LicenceKey | Required. The [3DMark](https://benchmarks.ul.com/3dmark?_ga=2.106445760.293481338.1681124251-1769566625.1681124251#windows) licence key| None| * **Profile Runtimes** The Timespy workload takes about 5-10 minutes to run depending on the performance of the target system. diff --git a/website/docs/workloads/3dmark/3dmark.md b/website/docs/workloads/3dmark/3dmark.md index 81231c12b0..854dfb9506 100644 --- a/website/docs/workloads/3dmark/3dmark.md +++ b/website/docs/workloads/3dmark/3dmark.md @@ -7,6 +7,6 @@ ## Workload Metrics This workload captures the fps and aggregate scores from the TimeSpy GPU and CPU tests. ## Packaging and Setup -Users are expected to provide their own binaries and lisences for this workload. This package is not hosted on the VC blob store. +Users are expected to provide their own binaries and licences for this workload. This package is not hosted on the VC blob store. diff --git a/website/docs/workloads/deathstarbench/deathstarbench.md b/website/docs/workloads/deathstarbench/deathstarbench.md index 1aa3540795..464727486f 100644 --- a/website/docs/workloads/deathstarbench/deathstarbench.md +++ b/website/docs/workloads/deathstarbench/deathstarbench.md @@ -18,7 +18,7 @@ This toolset was compiled from the github repo to integrate into VirtualClient. * [DeathStarBench Research paper](https://gy1005.github.io/publication/2019.asplos.deathstarbench/2019.asplos.deathstarbench.pdf?msclkid=1b5071f9d01a11ec8f1946ebedfa484d) ## What is Being Measured? -DeathStarBench is designed to anlayze network communication latencies and throughput between client and server systems. It produces different percentile latencies for network +DeathStarBench is designed to analyze network communication latencies and throughput between client and server systems. It produces different percentile latencies for network communication and also data transfer/sec for each HTTP request. ### Workload Metrics diff --git a/website/docs/workloads/fio/fio-profiles.md b/website/docs/workloads/fio/fio-profiles.md index 2d84a7d8dc..530d97b9d8 100644 --- a/website/docs/workloads/fio/fio-profiles.md +++ b/website/docs/workloads/fio/fio-profiles.md @@ -11,7 +11,7 @@ parameter (see below) by default. * [Workload Profile](https://github.com/microsoft/VirtualClient/blob/main/src/VirtualClient/VirtualClient.Main/profiles/PERF-IO-FIO.json) -Additonally this profile is designed to auto-scale to the number of cores on the system on which it runs. It uses a simple algorithm to determine 2 key +Additionally this profile is designed to auto-scale to the number of cores on the system on which it runs. It uses a simple algorithm to determine 2 key aspects of the workload execution. * Total number of jobs/threads = \<# of logical cores> / 2 @@ -231,7 +231,7 @@ Therefore, they are performed on different disks | SequentialWriteNumJobs | Sequential write component's Number of jobs. If it is provided it overwrites the DefaultNumJobs for Sequential write component. | | ProcessModel | Allows the user to override the default value you can selection Single Process for all disk(SingleProcess) or 1 process for each disk under test (SingleProcessPerDisk). | | Scenario | Scenario use to define the given action of profile | - | Tags | Tags usefull for telemetry data | + | Tags | Tags useful for telemetry data | * **Profile Runtimes** See the 'Metadata' section of the profile for estimated runtimes. These timings represent the length of time required to run a single round of profile diff --git a/website/docs/workloads/geekbench/geekbench.md b/website/docs/workloads/geekbench/geekbench.md index 94387d76b9..02ba54742f 100644 --- a/website/docs/workloads/geekbench/geekbench.md +++ b/website/docs/workloads/geekbench/geekbench.md @@ -232,7 +232,7 @@ GeekBench6 runs a corresponding single-core and multi-core version for each of t | PDF Rendering | Parses and renders a PDF using the PDFium library | | Photo Library | Runs image classification to categorize and tag photos based on the objects they contain | | Clang | Compiles a C source file using AArch64 as the target architecture | -| Text Processing | Loads files, parses them with regex, stores metadata in SQLite databse, and exports content to different format | +| Text Processing | Loads files, parses them with regex, stores metadata in SQLite database, and exports content to different format | | Asset Compression | Compresses 3D textural and geometric assets using a variety of popular compression codecs (ASTC, BC7, DXT5) | | Object Detection | Uses CNN to detect and classify objects in photo and then highlights them in photo | | Background Blur | Separates background from foreground in a video stream and blurs the background | diff --git a/website/docs/workloads/hplinpack/hplinpack-profiles.md b/website/docs/workloads/hplinpack/hplinpack-profiles.md index 0f8d0a7ce4..3a512db66b 100644 --- a/website/docs/workloads/hplinpack/hplinpack-profiles.md +++ b/website/docs/workloads/hplinpack/hplinpack-profiles.md @@ -16,7 +16,7 @@ This profile is designed to identify general/broad regressions when compared aga * linux-x64 * linux-arm64 -* **Supported Linux Distrbutions** +* **Supported Linux Distributions** * Ubuntu **Note**: Performance Libraries are enabled only for **Linux ARM-Ubuntu22.04 with gcc 11** as of now. Performance Libraries for AMD and Intel will be enabled soon. @@ -42,7 +42,7 @@ This profile is designed to identify general/broad regressions when compared aga | ProblemSizeN | The order of coefficient matrix of set of linear equations that we want to solve | Convert.ToInt32(Math.Sqrt(totalAvailableMemoryKiloBytes * 1024 * 0.8 / 8)) (This value is dependent on memory of machine, uses 80% of available memory) | | BlockSizeNB | The partitioning blocking factor | 256 | | PerformanceLibrary | Optional. This parameter allows you to specify machine-specific performance libraries. You can assign values such as ARM, AMD, and INTEL to utilize the corresponding performance libraries. | null | - | PerformanceLibraryVersion | Optional, but required when using PerformanceLibrary parameter. Specify the version of the performance libraries you would like to use.

Curently, the supported configurations are :
ARM - 23.04.1, 24.10 and 25.04.1 | null | | CCFLAGS | compiler flags| -O3 -march=native | + | PerformanceLibraryVersion | Optional, but required when using PerformanceLibrary parameter. Specify the version of the performance libraries you would like to use.

Currently, the supported configurations are :
ARM - 23.04.1, 24.10 and 25.04.1 | null | | CCFLAGS | compiler flags| -O3 -march=native | | BindToCores | If you want to bind the process to single core | false| | NumberOfProcesses | Number of processes to be launched for the parallel program | No. of logical cores| diff --git a/website/docs/workloads/hplinpack/hplinpack.md b/website/docs/workloads/hplinpack/hplinpack.md index 2b805974d0..637aeeabfb 100644 --- a/website/docs/workloads/hplinpack/hplinpack.md +++ b/website/docs/workloads/hplinpack/hplinpack.md @@ -1,7 +1,7 @@ # HPLINPACK HPL stands for High Performance Linpack, is a software package that solves a (random) dense linear system in double precision (64 bits) arithmetic on distributed-memory computers. It can thus be regarded as a portable as well as freely available implementation of the High Performance Computing Linpack Benchmark. -* [HPLINPACK Offical Website](https://netlib.org/benchmark/hpl/) +* [HPLINPACK Official Website](https://netlib.org/benchmark/hpl/) * [HPLINPACK Installation Guide](https://netlib.org/benchmark/hpl/software.html) ## What is Being Measured? diff --git a/website/docs/workloads/lapack/lapack.md b/website/docs/workloads/lapack/lapack.md index 24db2c3421..5a33db93ed 100644 --- a/website/docs/workloads/lapack/lapack.md +++ b/website/docs/workloads/lapack/lapack.md @@ -5,7 +5,7 @@ It has been designed to be efficient on a wide range of modern high-performance This toolset was compiled from the official website and modified so that it is easier to integrate into VirtualClient. -* [LAPACK Offical Website](http://www.netlib.org/lapack/) +* [LAPACK Official Website](http://www.netlib.org/lapack/) * [LAPACK Github](https://github.com/Reference-LAPACK/lapack) * [LAPACK Installation Guide](http://www.netlib.org/lapack/lawnspdf/lawn41.pdf) diff --git a/website/docs/workloads/memcached/memcached-profiles.md b/website/docs/workloads/memcached/memcached-profiles.md index 51c77e69f0..3757ebe22f 100644 --- a/website/docs/workloads/memcached/memcached-profiles.md +++ b/website/docs/workloads/memcached/memcached-profiles.md @@ -79,7 +79,7 @@ Runs the Memtier workload against to generate various network traffic patterns a | EmitAggregateMetrics | Optional. "True" to emit aggregate/rollup metrics from all individual Memtier client/Redis server request streams. The profile executes a Redis server per logical processor on the system and can thus emit a lot of metrics. As such emitting the metrics as aggregates of all Redis server processes may be desirable. | false | | EmitRawMetrics | Optional. "True" to emit the raw metrics from each individual Memtier client/Redis server request stream. This is the default option.. | true | | Duration | Optional. Defines the length of time to execute the Memtier benchmark operations against the Memcached server for each scenario in the profile. | 2 mins | - | ServerMaxConnections | Optional. The Maxium number of connections the Memcached server will allow. This allows the user to adjust alongside the number of client instances for higher scale situations. | | + | ServerMaxConnections | Optional. The Maximum number of connections the Memcached server will allow. This allows the user to adjust alongside the number of client instances for higher scale situations. | | | ServerPort | Optional. The initial port on which the Memcached server will listen for traffic. | 6379 | * **Component Parameters** diff --git a/website/docs/workloads/mlperf/mlperf-developer-guide.md b/website/docs/workloads/mlperf/mlperf-developer-guide.md index af6e1393d4..40921b796f 100644 --- a/website/docs/workloads/mlperf/mlperf-developer-guide.md +++ b/website/docs/workloads/mlperf/mlperf-developer-guide.md @@ -200,7 +200,7 @@ The json output will include a valid/invalid output, and either the latency or t - **make run RUN_ARGS='--benchmarks=bert --scenarios=Offline,Server,SingleStream --config_ver=default --test_mode=AccuracyOnly --fast**: Run accuracy mode which focuses on the accuracy of the model's predictions. In this example, the command will run the bert benchmark, with Offline, Server, and Single Stream scenarios, using the default config version, in accuracy only mode, and with fewer iterations for faster turnaround time. -The json output will inculde a pass/fail output, and the accuracy score. For example this is the json output for the Offline scenario: +The json output will include a pass/fail output, and the accuracy score. For example this is the json output for the Offline scenario: ``` { "accuracy": [ diff --git a/website/docs/workloads/mlperf/mlperf.md b/website/docs/workloads/mlperf/mlperf.md index 94ec844776..e9ceb0d378 100644 --- a/website/docs/workloads/mlperf/mlperf.md +++ b/website/docs/workloads/mlperf/mlperf.md @@ -45,7 +45,7 @@ GPU components for which the MLPerf workload is designed to test. Source: [link](https://github.com/mlcommons/training_results_v2.1/tree/main/NVIDIA/benchmarks/bert/implementations/pytorch-22.09) -Additional details on whether a system is supported or not can be found in the documetation here, +Additional details on whether a system is supported or not can be found in the documentation here, for each benchmark check it's respective implementation folder : https://github.com/mlcommons/training_results_v2.1/tree/main/NVIDIA/benchmarks https://github.com/mlcommons/inference_results_v4.1/tree/master/closed/NVIDIA diff --git a/website/docs/workloads/nasparallel/nasparallel-profiles.md b/website/docs/workloads/nasparallel/nasparallel-profiles.md index 830ce9216c..9e5c218be4 100644 --- a/website/docs/workloads/nasparallel/nasparallel-profiles.md +++ b/website/docs/workloads/nasparallel/nasparallel-profiles.md @@ -77,12 +77,12 @@ For different benchmarks with NAS Parallel we have various recommendation on num ``` ## SSH Requirements -OpenMPI sends messages over port 22 - as well as expects to send messages without having to supply a key or passsword. A secure and safe way is to register an SSH identity with the +OpenMPI sends messages over port 22 - as well as expects to send messages without having to supply a key or password. A secure and safe way is to register an SSH identity with the client machine. Here is an example [blog post](https://linuxize.com/post/how-to-setup-passwordless-ssh-login/) on how to do this. Although the basic steps are: - On client, store a private-public key pair under ~/.ssh/id_rsa and ~/.ssh/id_rsa.pub - On server, append the id_rsa.pub generated under ~/.ssh/authorized_keys - On client, store server fingprints in ~/.ssh/known_hosts -- Last when running the profile, supply the username whos .ssh directory contains all of the files just created/edited. +- Last when running the profile, supply the username whose .ssh directory contains all of the files just created/edited. ## PERF-HPC-NASPARALLELBENCH.json Runs a set of HPC workloads using NAS Parallel Benchmarks to the parallel computing performance. This profile is designed to test both single and diff --git a/website/docs/workloads/prime95/prime95.md b/website/docs/workloads/prime95/prime95.md index afe5e371b8..f6e8925a1d 100644 --- a/website/docs/workloads/prime95/prime95.md +++ b/website/docs/workloads/prime95/prime95.md @@ -4,7 +4,7 @@ and system builders. The software feeds the the processor a barrage of integer a consistently verified with the goal of testing the stability of the CPU and L1/L2/L3 processor caches. Additionally, it utilizes all of the cores on the system to ensure a consistently high stress test environment. -Prime95 is designed to run indefinately on a system till any error is encountered. The workload is onboarded to the Virtual Client with the goal +Prime95 is designed to run indefinitely on a system till any error is encountered. The workload is onboarded to the Virtual Client with the goal of supporting a dual-purpose: to test the performance/timing of the CPU in computing the calculations while also placing it under stress. * [Prime95 Documentation](https://www.mersenne.org/download/) @@ -47,7 +47,7 @@ The following list describes the measurements captured by the workload running a The following metrics are examples of those captured by the Virtual Client when running the Prime95 workload. :::info -*Note that if the failed test count is greater than 0, it denotes an overall Prime95 test failure and some harware error. The test time is the time +*Note that if the failed test count is greater than 0, it denotes an overall Prime95 test failure and some hardware error. The test time is the time for which the system was stressed with torture test. A higher the test time without error typically indicates more confidence in Prime95 results.* ::: diff --git a/website/docs/workloads/speccpu/speccpu.md b/website/docs/workloads/speccpu/speccpu.md index 3d1ccb0efd..461419ee96 100644 --- a/website/docs/workloads/speccpu/speccpu.md +++ b/website/docs/workloads/speccpu/speccpu.md @@ -1,5 +1,5 @@ # SPECcpu -SPEC CPU is a workload created and licensed by the Standard Performance Evalution Corporation. The SPEC CPU® 2017 benchmark package contains SPEC's +SPEC CPU is a workload created and licensed by the Standard Performance Evaluation Corporation. The SPEC CPU® 2017 benchmark package contains SPEC's next-generation, industry-standardized, CPU intensive suites for measuring and comparing compute intensive performance, stressing a system's processor, memory subsystem and compiler. diff --git a/website/docs/workloads/specpower/specpower.md b/website/docs/workloads/specpower/specpower.md index 1005fedd1c..3c2ec10752 100644 --- a/website/docs/workloads/specpower/specpower.md +++ b/website/docs/workloads/specpower/specpower.md @@ -1,5 +1,5 @@ # SPECpower -SPEC Power is a workload created and licensed by the Standard Performance Evalution Corporation and is an industry standard benchmark +SPEC Power is a workload created and licensed by the Standard Performance Evaluation Corporation and is an industry standard benchmark toolset for measuring power/energy consumption on a system. * [SPEC Power Documentation](https://www.spec.org/power_ssj2008/#:~:text=The%20SPEC%20Power%20benchmark%20is%20the%20first%20industry-standard,a%20toolset%20for%20use%20in%20improving%20server%20efficiency.) diff --git a/website/docs/workloads/stress-ng/stress-ng-profiles.md b/website/docs/workloads/stress-ng/stress-ng-profiles.md index ffd1c92059..60d453f93c 100644 --- a/website/docs/workloads/stress-ng/stress-ng-profiles.md +++ b/website/docs/workloads/stress-ng/stress-ng-profiles.md @@ -31,7 +31,7 @@ Runs the Stress-ng workload in short but constant bursts to assess the performan | Parameter | Purpose | Default Value | Note | |-----------|---------|---------------|------| - | CommandLine | The CommandLine Arguments to be provided to StressNg | "--timeout 60" | "The commandline parameter --yaml is programatically added, do not add it in profile. By default, --metrics flag is ON, --cpu is set to ProcessorCount and the default timeout is 60 seconds." | + | CommandLine | The CommandLine Arguments to be provided to StressNg | "--timeout 60" | "The commandline parameter --yaml is programmatically added, do not add it in profile. By default, --metrics flag is ON, --cpu is set to ProcessorCount and the default timeout is 60 seconds." | * **Profile Runtimes** See the 'Metadata' section of the profile for estimated runtimes. These timings represent the length of time required to run a single round of profile diff --git a/website/docs/workloads/stressapptest/stressapptest.md b/website/docs/workloads/stressapptest/stressapptest.md index 6dfa0db886..8de8700aff 100644 --- a/website/docs/workloads/stressapptest/stressapptest.md +++ b/website/docs/workloads/stressapptest/stressapptest.md @@ -28,7 +28,7 @@ if the physical components overheat. The following metrics are examples of those captured by the Virtual Client when running the StressAppTest workload. :::info -*Note that if the hardwareErrorCount is greater than 0, it denotes an overall StressAppTest failure and some harware error, possibly in the DIMM. +*Note that if the hardwareErrorCount is greater than 0, it denotes an overall StressAppTest failure and some hardware error, possibly in the DIMM. The DIMM Slot and other details, as captured by StressAppTest, is added as a "Tag" of the hardwareErrorCount metric, for ease of debugging.* ::: diff --git a/website/docs/workloads/superbenchmark/superbenchmark.md b/website/docs/workloads/superbenchmark/superbenchmark.md index 3cd304bb89..14b1396fa3 100644 --- a/website/docs/workloads/superbenchmark/superbenchmark.md +++ b/website/docs/workloads/superbenchmark/superbenchmark.md @@ -199,10 +199,10 @@ or AMD [rocblas-bench](https://github.com/ROCmSoftwarePlatform/rocBLAS/tree/deve | Name | Unit | Description | |----------------------------------------|------------------|-------------------------------------------------------------| - | nccl-bw/$\{operation}_$\{msg_size}_time | time (us) | NCCL operation lantency with given message size. | + | nccl-bw/$\{operation}_$\{msg_size}_time | time (us) | NCCL operation latency with given message size. | | nccl-bw/$\{operation}_$\{msg_size}_algbw | bandwidth (GB/s) | NCCL operation algorithm bandwidth with given message size. | | nccl-bw/$\{operation}_$\{msg_size}_busbw | bandwidth (GB/s) | NCCL operation bus bandwidth with given message size. | - | rccl-bw/$\{operation}_$\{msg_size}_time | time (us) | RCCL operation lantency with given message size. | + | rccl-bw/$\{operation}_$\{msg_size}_time | time (us) | RCCL operation latency with given message size. | | rccl-bw/$\{operation}_$\{msg_size}_algbw | bandwidth (GB/s) | RCCL operation algorithm bandwidth with given message size. | | rccl-bw/$\{operation}_$\{msg_size}_busbw | bandwidth (GB/s) | RCCL operation bus bandwidth with given message size. | @@ -211,10 +211,10 @@ or AMD [rocblas-bench](https://github.com/ROCmSoftwarePlatform/rocBLAS/tree/deve | Metrics | Unit | Description | |-------------------------------------------------|-----------|---------------------------------------------------------------------------------------| - | tcp-connectivity/$\{hostname/ip}_successed_count | count | successed times of tcp connections between current node and other nodes | + | tcp-connectivity/$\{hostname/ip}_succeeded_count | count | succeeded times of tcp connections between current node and other nodes | | tcp-connectivity/$\{hostname/ip}_failed_count | count | failed times of tcp connections between current node and other nodes | | tcp-connectivity/$\{hostname/ip}_success_rate | | success rate (successed/total) of tcp connection between current node and other nodes | - | tcp-connectivity/$\{hostname/ip}_time_min | time (ms) | mininum latency of tcp connections between current node and other nodes | + | tcp-connectivity/$\{hostname/ip}_time_min | time (ms) | minimum latency of tcp connections between current node and other nodes | | tcp-connectivity/$\{hostname/ip}_time_max | time (ms) | maximum latency of tcp connections between current node and other nodes | | tcp-connectivity/$\{hostname/ip}_time_avg | time (ms) | average latency of tcp connections between current node and other nodes | diff --git a/website/docs/workloads/sysbench/sysbench-addendum.md b/website/docs/workloads/sysbench/sysbench-addendum.md index 3dd75571bf..1abfa01ccb 100644 --- a/website/docs/workloads/sysbench/sysbench-addendum.md +++ b/website/docs/workloads/sysbench/sysbench-addendum.md @@ -58,7 +58,7 @@ the database on one or multiple disks, Sysbench will go ahead and place the tabl * **Threads** The Sysbench workload generator prepares a list of statements to run on MySQL. MySQL can only accept so many prepared statements. We already max out this variable in a - scenario in the MySQLConfiguation dependency, but even when setting the max_prepared_stmt_count to a large number, Sysbench can throw a 'too many connections' error. This has shown + scenario in the MySQLConfiguration dependency, but even when setting the max_prepared_stmt_count to a large number, Sysbench can throw a 'too many connections' error. This has shown to be the case even on VMs with high core counts and equipped with the ability for high thread counts. User caution is advised for thread counts > 176; the VC team has only successfully seen Sysbench run with thread counts less than that number. @@ -80,4 +80,5 @@ sysbench oltp_common --tables=10 --table-size=100 --mysql-db=sbtest --mysql-host # running the oltp_write_only workload sysbench oltp_write_only --threads=10 --tables=10 --table-size=100 --mysql-db=sbtest --mysql-host=1.2.3.4 --time=600 run -``` \ No newline at end of file +``` +