Skip to content

Fix: Prevent littering of %temp%, changed dependency override path #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beanbag44 merged 1 commit into from
Jan 26, 2026
Merged

Fix: Prevent littering of %temp%, changed dependency override path #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/main/kotlin/com/lambda/loader/util/FabricUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,23 @@ object FabricUtil {
/**
* Loads nested JARs from META-INF/jars/ directory and adds them to classpath
* Fabric Loader stores bundled dependencies in this directory for jar-in-jar functionality
* Extracts nested JARs to temp directory for classpath access
* Extracts nested JARs to a consistent temp directory that's cleared on each run
*/
fun loadNestedJars(jarFile: File): List<Path> {
val nestedJarPaths = mutableListOf<Path>()

try {
// Create temp directory for nested JARs
val tempDir = Files.createTempDirectory("lambda-loader-nested")
// Use a consistent temp directory location
val tempDir = Path.of(System.getProperty("java.io.tmpdir"), "lambda-loader-nested")

// Clear the directory if it exists, then recreate it
if (Files.exists(tempDir)) {
Files.walk(tempDir)
.sorted(Comparator.reverseOrder())
.forEach { Files.deleteIfExists(it) }
}
Files.createDirectories(tempDir)

if (ConfigManager.config.debug) {
logger.info("Created temp directory for nested JARs: $tempDir")
}
Expand Down Expand Up @@ -143,10 +152,8 @@ object FabricUtil {

val versionOverrides = VersionOverrides()

// DependencyOverrides takes a Path parameter - use a temporary directory
val tempPath = Files.createTempDirectory("lambda-loader-deps")
val depOverrides = DependencyOverrides(tempPath)

// DependencyOverrides takes a Path parameter - use empty path since it isn't used
val depOverrides = DependencyOverrides(Path.of(""))
val metadata = parseMetadataMethod.invoke(
null, // static method
zip.getInputStream(entry),
Expand Down