Stop using "ClassLoadingStrategy.Default.INJECTION"

[ptziegler]

This causes an exception when opening the following snippet:

package test;

import org.eclipse.swt.SWT;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Shell;

public class Test extends Shell {

	/**
	 * Create the shell.
	 * @param display
	 */
	public Test(Display display) {
		super(display, SWT.SHELL_TRIM);
		setText("SWT Application");
		setSize(450, 300);
	}

	@Override
	protected void checkSubclass() {
		// Disable the check that prevents subclassing of SWT components
	}
}

Exception during 'super' constructor evaluation

An exception happened during evaluation of constructor Shell(Display,int) using arguments {org.eclipse.swt.widgets.Display@2776fd8f,1264}.

java.lang.UnsupportedOperationException: Cannot define class using reflection: Unable to make protected java.lang.Package java.lang.ClassLoader.getPackage(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @550244cb
	at net.bytebuddy.dynamic.loading.ClassInjector$UsingReflection$Dispatcher$Initializable$Unavailable.defineClass(ClassInjector.java:472)
	at net.bytebuddy.dynamic.loading.ClassInjector$UsingReflection.injectRaw(ClassInjector.java:284)
	at net.bytebuddy.dynamic.loading.ClassInjector$AbstractBase.inject(ClassInjector.java:118)
	at net.bytebuddy.dynamic.loading.ClassLoadingStrategy$Default$InjectionDispatcher.load(ClassLoadingStrategy.java:241)
	at net.bytebuddy.dynamic.loading.ClassLoadingStrategy$Default.load(ClassLoadingStrategy.java:148)
	at net.bytebuddy.dynamic.TypeResolutionStrategy$Passive.initialize(TypeResolutionStrategy.java:101)
	at net.bytebuddy.dynamic.DynamicType$Default$Unloaded.load(DynamicType.java:6325)

[ptziegler]

See #1307

[ptziegler]

windowbuilder/org.eclipse.wb.core.java/src/org/eclipse/wb/internal/core/model/creation/ThisCreationSupport.java

Lines 407 to 417 in 941c788

	private void createEnhancer(Class<?> componentClass, final ExecutionFlowFrameVisitor visitor) {
	final TypeCache.SimpleKey proxyKey = new TypeCache.SimpleKey(componentClass);
	DynamicType.Builder<?> builder = new ByteBuddy()
	.subclass(componentClass) //
	.defineField(MethodInterceptor.FIELD_INTERCEPTOR, MethodInterceptor.class, Modifier.PRIVATE)
	.method(ElementMatchers.noneOf(getIgnoredMethods(componentClass))) //
	.intercept(MethodDelegation.to(new StubMethodInterceptor(), MethodInterceptor.class));
	PROXY_CACHE.findOrInsert(getClassLoader(), proxyKey, () -> builder.make().load(getClassLoader(), ClassLoadingStrategy.Default.INJECTION).getLoaded());
	}

windowbuilder/org.eclipse.wb.rcp/src/org/eclipse/wb/internal/rcp/model/widgets/DialogInfo.java

Lines 199 to 204 in 941c788

	return new ByteBuddy()
	.subclass(classLoader.loadClass("org.eclipse.swt.widgets.Dialog")) //
	.name("org.eclipse.swt.widgets.Dialog_") //
	.make() // We have to use injection to load the class in the CreationSupport
	.load(classLoader, ClassLoadingStrategy.Default.INJECTION) //
	.getLoaded();