Skip to content

Set INSTANCE_UNREACHABLE for unreachable on-demand instances #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Jan 26, 2026
Merged

Set INSTANCE_UNREACHABLE for unreachable on-demand instances #3497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/dstack/_internal/server/background/tasks/process_running_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,12 @@ async def _process_running_job(session: AsyncSession, job_model: JobModel):
# No job_model.termination_reason set means ssh connection failed
_set_disconnected_at_now(session, job_model)
if _should_terminate_job_due_to_disconnect(job_model):
# TODO: Replace with JobTerminationReason.INSTANCE_UNREACHABLE for on-demand.
job_model.termination_reason = JobTerminationReason.INTERRUPTED_BY_NO_CAPACITY
if job_provisioning_data.instance_type.resources.spot:
job_model.termination_reason = (
JobTerminationReason.INTERRUPTED_BY_NO_CAPACITY
)
else:
job_model.termination_reason = JobTerminationReason.INSTANCE_UNREACHABLE
job_model.termination_reason_message = "Instance is unreachable"
switch_job_status(session, job_model, JobStatus.TERMINATING)
else:
Expand Down
2 changes: 1 addition & 1 deletion src/tests/_internal/server/background/tasks/test_process_running_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ async def test_pulling_shim_failed(self, test_db, session: AsyncSession):
assert SSHTunnelMock.call_count == 3
await session.refresh(job)
assert job.status == JobStatus.TERMINATING
assert job.termination_reason == JobTerminationReason.INTERRUPTED_BY_NO_CAPACITY
assert job.termination_reason == JobTerminationReason.INSTANCE_UNREACHABLE
assert job.remove_at is None

@pytest.mark.asyncio
Expand Down