Skip to content

Refs #6049: Fix verbose ctuPointerArith message #8162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Jan 29, 2026
+28 −1
Merged

Refs #6049: Fix verbose ctuPointerArith message #8162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9be3c3
Update ctu.cpp
chrchr-github Jan 28, 2026
4eab2d5
Update testbufferoverrun.cpp
chrchr-github Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/ctu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,20 @@ static bool findPath(const std::string &callId,
return false;
}

static std::string getInvalidValueString(CTU::FileInfo::InvalidValueType invalidValue)
{
using InvalidValueType = CTU::FileInfo::InvalidValueType;
switch (invalidValue) {
case InvalidValueType::null:
return "null";
case InvalidValueType::uninit:
return "uninitialized";
case InvalidValueType::bufferOverflow:
return "accessed out of bounds";
}
cppcheck::unreachable();
}

std::list<ErrorMessage::FileLocation> CTU::FileInfo::getErrorPath(InvalidValueType invalidValue,
const CTU::FileInfo::UnsafeUsage &unsafeUsage,
const std::map<std::string, std::list<const CTU::FileInfo::CallBase *>> &callsMap,
Expand All @@ -581,7 +595,7 @@ std::list<ErrorMessage::FileLocation> CTU::FileInfo::getErrorPath(InvalidValueTy

std::list<ErrorMessage::FileLocation> locationList;

const std::string value1 = (invalidValue == InvalidValueType::null) ? "null" : "uninitialized";
const std::string value1 = getInvalidValueString(invalidValue);

for (int index = 9; index >= 0; index--) {
if (!path[index])
Expand Down
13 changes: 13 additions & 0 deletions test/testbufferoverrun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5515,6 +5515,19 @@ class TestBufferOverrun : public TestFixture {
" f(s);\n"
"}\n");
ASSERT_EQUALS("", errout_str());

setMultiline();
ctu("void g(char* p) {\n"
" memset(p + 10, 0, 10);\n"
"}\n"
"void f() {\n"
" char a[10] = {};\n"
" g(a);\n"
"}");
ASSERT_EQUALS("[test.cpp:2:12]: error: Pointer arithmetic overflow; 'p' buffer size is 10 [ctuPointerArith]\n"
"[test.cpp:6:6]: note: Calling function g, 1st argument is accessed out of bounds\n"
"[test.cpp:2:12]: note: Using argument p\n",
errout_str());
}

void objectIndex() {
Expand Down
Loading