fix: Remove unnecessary trafficker_id requirement from GAM creatives_manager #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manager initialization The GAMCreativesManager does not actually use trafficker_id (only GAMOrdersManager does), but the initialization check was requiring both advertiser_id AND trafficker_id. This caused creatives_manager to be None when trafficker_id was not configured, resulting in creative uploads being silently skipped during media buy approval. The order/line items would be created in GAM, but no creatives would be associated. Root cause: When gam_trafficker_id is NULL in adapter_config, it becomes an empty string which is falsy, causing the condition 'if self.advertiser_id and self.trafficker_id' to evaluate to False even when advertiser_id is properly set. Fix: Only check for advertiser_id since that's all GAMCreativesManager needs.
Upgrade python-multipart from 0.0.21 to 0.0.22 to fix security vulnerability.
bokelley
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Erin found a bug in the sales agent,
When approving a media buy with GAM adapter, creatives were not being uploaded to GAM even though:
GAM would show "Needs creatives (1)" on the line item.
Ticket: https://linear.app/scope3-projects/issue/PRO-88/hosted-sales-agent-creative-assignment-not-making-it-into-gam
Root Cause
The
GAMCreativesManagerinitialization ingoogle_ad_manager.pywas checking for bothadvertiser_idANDtrafficker_id:However,
GAMCreativesManagerdoes not actually usetrafficker_id- onlyGAMOrdersManagerdoes.When
gam_trafficker_idisNULLin theadapter_configtable, it becomes an empty string""which is falsy in Python. This causedcreatives_managerto be set toNone, and during approval the creative upload was silently skipped with the warning:Fix
Remove the unnecessary
and self.trafficker_idcheck sinceGAMCreativesManageronly needsadvertiser_id.The comment on that line already said "Only initialize creative manager if we have advertiser_id" - the code just didn't match the comment.
Testing
tests/unit/test_gam_creatives_manager.py- 5 tests pass