feat: Add get_adcp_capabilities tool for AdCP v3 compliance #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the get_adcp_capabilities endpoint that was missing from the v3 migration. This tool returns honest capability declarations about what the sales agent supports, including channels from the adapter and targeting options from the underlying ad server. - Adds TargetingCapabilities dataclass to adapter interface - Adapters (GAM, Mock, Triton, Kevel) now report targeting support - Capabilities response includes publisher domains, channels, and geo targeting - Tool available via both MCP and A2A protocols - Includes comprehensive unit tests for schema validation Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add get_adcp_capabilities to DISCOVERY_SKILLS for public access - Add skill handler to skill_handlers dict in A2A server - Add skill to AgentCard skills list - Implement _handle_get_adcp_capabilities_skill method - Improve human-readable output in MCP ToolResult - Add comprehensive tests with mocked tenant context Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add get_adcp_capabilities to ALL_TOOLS in test_tool_registration.py - Add get_adcp_capabilities to expected skills in test_skill_handler_mapping - Upgrade python-multipart 0.0.21 -> 0.0.22 (fixes GHSA-wp53-j4wj-2cfg) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove hardcoded/static skills that returned fake data instead of real capabilities: - Remove get_pricing and get_targeting from skill_handlers - Remove from AgentCard skills list - Remove _get_pricing() and _get_targeting() method implementations - Update natural language handling to route pricing queries to get_products and targeting queries to get_adcp_capabilities - Remove associated tests that tested the legacy skills The agent now returns 13 real skills that all use actual tools. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the get_adcp_capabilities endpoint that was missing from the v3 migration. This tool returns honest capability declarations about what the sales agent supports, including channels from the adapter and targeting options from the underlying ad server.
All 1471 unit tests pass, plus 33 integration and 8 integration_v2 tests verified.