Skip to content

Silently fails to save recording if recordingPath contains nonexistent parent directories #93

@Kastet

Description

@Kastet

Hi,

Thanks for your effort, the library is really easy to use and is a great help!

Currently,

let recordingPath = "\(nonexistentParentDirectory)/\(testName).json"
let recordingMode = RecordingMode.missingVinyl(recordingPath: recordingPath)

will result in Vinyl's Recorder silently failing to save newly recorded vinyl.

Suggest adding an error case into TurntableError for throwing there instead of silent return.

Happy to send a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions