Skip to content

feat: fix get_nodes #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarltonXiang merged 4 commits into from
Jan 28, 2026
+13 −16
Merged

feat: fix get_nodes #971

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0336f9c
feat: fix get_nodes
wustzdy Jan 28, 2026
0e865e1
feat: fix get_nodes
wustzdy Jan 28, 2026
52868bc
feat: fix get_nodes
wustzdy Jan 28, 2026
11243d8
feat: optimize get_nodes
wustzdy Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions src/memos/graph_dbs/polardb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,30 +1130,27 @@ def get_nodes(
- Assumes all provided IDs are valid and exist.
- Returns empty list if input is empty.
"""
logger.info(f"get_nodes ids:{ids},user_name:{user_name}")
if not ids:
return []

# Build WHERE clause using agtype_access_operator like get_node method
where_conditions = []
params = []

for id_val in ids:
where_conditions.append(
"ag_catalog.agtype_access_operator(properties, '\"id\"'::agtype) = %s::agtype"
)
params.append(self.format_param_value(id_val))

where_clause = " OR ".join(where_conditions)
# Build WHERE clause using IN operator with agtype array
# Use ANY operator with array for better performance
placeholders = ",".join(["%s"] * len(ids))
params = [self.format_param_value(id_val) for id_val in ids]

query = f"""
SELECT id, properties, embedding
FROM "{self.db_name}_graph"."Memory"
WHERE ({where_clause})
WHERE ag_catalog.agtype_access_operator(properties, '\"id\"'::agtype) = ANY(ARRAY[{placeholders}]::agtype[])
"""

user_name = user_name if user_name else self.config.user_name
query += " AND ag_catalog.agtype_access_operator(properties, '\"user_name\"'::agtype) = %s::agtype"
params.append(self.format_param_value(user_name))
# Only add user_name filter if provided
if user_name is not None:
query += " AND ag_catalog.agtype_access_operator(properties, '\"user_name\"'::agtype) = %s::agtype"
params.append(self.format_param_value(user_name))

logger.info(f"get_nodes query:{query},params:{params}")

conn = None
try:
Expand Down Expand Up @@ -4313,7 +4310,7 @@ def _build_user_name_and_kb_ids_conditions_sql(
user_name_conditions = []
effective_user_name = user_name if user_name else default_user_name

if effective_user_name and default_user_name != "xxx":
if effective_user_name:
user_name_conditions.append(
f"ag_catalog.agtype_access_operator(properties, '\"user_name\"'::agtype) = '\"{effective_user_name}\"'::agtype"
)
Expand Down