Notes don't use custom template unless explicitly specified for each repo

[steven-murray]

If I set the Global default "Content Template" to be custom, none of my issues/PRs use the template I set (even after deleting the entire Github/ folder and restarting Obsidian). However, if I update a particular repo to use custom content template then it works. But this means I have to make this manual switch for many repos. Is this a bug or am I misunderstanding something?

Thanks for the great plugin!

[LonoxX]

I think that's a bug. I'll take a look at it in the next few days.

[LonoxX]

The issue is fixed and included in the latest release

[steven-murray]

Thanks for looking at this -- however the update (v1.7.0) is not working for me. It has the same behavior as before. In my settings I have:

My custom template adds some tags (#task, #code) to the file properties but these do not show in my generated issue files.

[LonoxX]

Oh, I think the append mode ignores the template logic I'll take a look at that right away.

[LonoxX]

Okay, in my tests, the templates worked, at least when I deleted the files and recreated them, because only the content at the bottom is added.

[LonoxX]

I can't upload the video to this issue, so here is the YouTube link.

https://www.youtube.com/watch?v=-Q6YjeHBrek

[steven-murray]

Hmmm maybe I am misunderstanding the settings. I reduced my number of repos to just two, to make it easier/faster to figure out this issue.

My global settings are as in the screenshot above (so both Issues and PRs should use a custom template). Also, for both of my repos I have "Ignore global defaults" set to FALSE (so I should be using the global defaults). However, for Repo 1 I have the following repo-level settings:

Repo 1:

• Use Custom Issue Content Template: False (which is default)
• Track Issues: True (which is default)
• Track Pull Requests: True (which is not the default)
• Use custom pull request content template: True (which is not by default)

Repo 2:

• Use Custom Issue Content Template: False (default)
• Track Issues: True (default)
• Track Pull Requests: False (default)
• Use custom pull request content template: False (default)

The results are that PR notes are only made for Repo 1, and only the PR notes for Repo 1 use the custom template (i.e. not the Issues for either repo, and neither issues nor PRs for Repo 2).

This suggests that:

1. PRs are not tracked by default and must be turned on individually for each repo (there is no global default switch for this)
2. Using a custom template only works if the setting is turned to its non-default value of True for each repo, even if "ignore global defaults" is False.

Number (2) does not match the behavior you showed in the video posted above, which is strange. I just tried manually removing all my repos from the "Github Issues" configuration screen, then re-adding just two of them, deleting all the existing notes, then re-syncing. It did not use the specified custom templates.

Is there any more information I can give?

[steven-murray]

I've never written an obsidian plugin, or anything in typescript before, but could this line:

obsidian-github-issues/src/content-generator.ts

Line 32 in 79c7490

if (repo.useCustomIssueContentTemplate && repo.issueContentTemplate) {

be the issue? It's not using the meta-variable you defined the checks both the repo and global settings, rather just using the repo setting

[LonoxX]

Okay, I've made some more changes. Could you replace your main.js file and see if the problem still exists?

vault/.obsidian/plugins/github-issues/main.js

I'm also uploading my data.json file, perhaps there's something in there that I'm overlooking.

data.json